Merge lp:~psivaa/ubuntu-test-runlists/jenkins-smoketest-setup-1SS-move-update into lp:~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup

Proposed by Para Siva
Status: Merged
Merged at revision: 51
Proposed branch: lp:~psivaa/ubuntu-test-runlists/jenkins-smoketest-setup-1SS-move-update
Merge into: lp:~canonical-ci-engineering/ubuntu-test-runlists/jenkins-smoketest-setup
Diff against target: 27 lines (+3/-3)
1 file modified
setup-jobs.py (+3/-3)
To merge this branch: bzr merge lp:~psivaa/ubuntu-test-runlists/jenkins-smoketest-setup-1SS-move-update
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+195219@code.launchpad.net

Description of the change

Converting the IP's into host names and domain names due to the 1SS move. Have changed to hostname to the IP where the images are stored and changed to domain name for jenkins instance, believing that's the most appropriate.

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

untested, but looks fine.

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

Just out of curiosity, why are you using both of the names tachash and d-jenkins when they are the same system? I've been just using d-jenkins for that one.

Revision history for this message
Para Siva (psivaa) wrote :

@Paul: I wanted distinguish the jenkins instance from the host where the images are stored. Here, you could use the same (d-jenkins) for both but the images are stored in the host and that does not strictly need to be in the same jenkins host.

Revision history for this message
Para Siva (psivaa) wrote :

Not sure if that was clear.. for e.g. if we migrate jenkins to run somewhere else taking the d-jenkins name and keep the images stored in the same host (tachash) we will end up having issues, because then we will have two different ip's for both.

Revision history for this message
Paul Larson (pwlars) wrote :

Sure, I was just thinking it would be more likely that they decide to change the name tachash to something else, or move the entire thing over to a new server, than to change d-jenkins.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup-jobs.py'
2--- setup-jobs.py 2013-04-30 17:26:12 +0000
3+++ setup-jobs.py 2013-11-14 12:33:04 +0000
4@@ -43,7 +43,7 @@
5 epilog=("For example:\n"
6 "\t%(prog)s /path/to/branch -s " + DEV_SERIES +
7 " -u user -p pass -j http://jenkins:8080"
8- " -i http://10.98.0.1/iso/\n"),
9+ " -i http://tachash/iso/\n"),
10 formatter_class=argparse.RawDescriptionHelpFormatter)
11 parser.add_argument("branches", nargs='+',
12 help="Path(s) to branch(es) to process")
13@@ -63,12 +63,12 @@
14 group.add_argument("-p", "--password",
15 help="Password to use when logging into Jenkins")
16
17- parser.add_argument("-j", "--jenkins", default="http://10.189.74.2:8080/",
18+ parser.add_argument("-j", "--jenkins", default="http://d-jenkins.ubuntu-ci:8080/",
19 help="URL of jenkins instance to configure test in")
20 parser.add_argument("--node", default="aldebaran",
21 help=("Jenkins node were the job should be executed "
22 "(default=%(default)s)"))
23- parser.add_argument("-i", "--imageurl", default="http://10.98.0.1/iso/",
24+ parser.add_argument("-i", "--imageurl", default="http://tachash/iso/",
25 help="URL where images are located")
26 parser.add_argument("--prefix",
27 help=("Prefix to be used for job names. "

Subscribers

People subscribed via source and target branches

to all changes: