Merge lp:~psivaa/ubuntu-test-cases/skip-reminders into lp:ubuntu-test-cases/touch

[Para Siva]

Skip reminders until lp: 1349975 is fixed.

Have been asked to skip reminders until lp: 1349975 is fixed.

[Evan (ev)]

I don't think this is the correct approach. We shouldn't be hacking around buggy tests in the infrastructure. The problem should be fixed at the source, in the tests themselves.

In this instance, the developers could implement a per-test timeout within the reminders tests. In the future, they could use this feature from Autopilot itself:

https://code.launchpad.net/~thomir/autopilot/test-timeouts/+merge/233457

I'm going to reach out to the test owners on this.

review: Disapprove

[Evan (ev)]

As an example, you could decorate the test with a timeout function:

http://stackoverflow.com/questions/2281850/timeout-function-if-it-takes-too-long-to-finish

dpm is going to ask elopio and balloons to follow up here.

[Nicholas Skaggs (nskaggs)]

I will add a check to raise an error before going into the loop for when this condition occurs. The result will be that the test will fail immediately if a proper identity was not obtained. No timeout should be needed.

[Nicholas Skaggs (nskaggs)]

This merge is here:

https://code.launchpad.net/~nskaggs/reminders-app/fix-1381828/+merge/238519

[Evan (ev)]

Thanks for this. I think adding a timeout would make this safer still, but don't let me be prescriptive :)

[Leo Arias (elopio)]

Evan, there are some things that we should fix on the tests themselfs, like when we cause an infinite loop. But when we call an external library and it hangs, the only way to prevent an infinite test would be to wrap that call in a timer that will kill the test if expired. If we wrap all the calls to external methods, the code will be an unreadable mess. For those cases, what we need is a per test timeout. Thomi started working on that here: https://code.launchpad.net/~thomir/autopilot/test-timeouts/+merge/233457

[Evan (ev)]

Hi Leo,

I think you missed my opening comment where I pointed at that MP.

So, using an alarm signal (as I suggested above, not a basic timer) to wrap setUp of your base test class would not make the code an unreadable mess. It's one function and one decorator.

Unmerged revisions

321. By Para Siva on 2014-10-15

Disable reminders until lp: 1349975 is fixed

=== modified file 'jenkins/testconfig.py'
--- jenkins/testconfig.py	2014-09-19 16:10:39 +0000
+++ jenkins/testconfig.py	2014-10-15 09:17:28 +0000
@@ -57,9 +57,9 @@
     APTest('dialer-app-autopilot', pkgs=['dialer-app-autopilot']),
     APTest('messaging-app-autopilot', pkgs=['messaging-app-autopilot']),
     APTest('address-book-app-autopilot', pkgs=['address-book-app-autopilot']),
-    APTest('reminders-autopilot',
-           pkgs=['python3-dbusmock', 'python3-requests-oauthlib',
-                 'account-plugin-evernote-sandbox']),
+    # APTest('reminders-autopilot',
+    #       pkgs=['python3-dbusmock', 'python3-requests-oauthlib',
+    #             'account-plugin-evernote-sandbox']),
     APTest('music-app-autopilot'),
     APTest('dropping-letters-app-autopilot'),
     APTest('sudoku-app-autopilot'),