Merge lp:~psivaa/ubuntu-test-cases/rsync-results-to-tachash into lp:~canonical-ci-engineering/ubuntu-test-cases/boottest

Proposed by Para Siva
Status: Merged
Merged at revision: 400
Proposed branch: lp:~psivaa/ubuntu-test-cases/rsync-results-to-tachash
Merge into: lp:~canonical-ci-engineering/ubuntu-test-cases/boottest
Diff against target: 33 lines (+10/-2)
1 file modified
scripts/boottest.sh (+10/-2)
To merge this branch: bzr merge lp:~psivaa/ubuntu-test-cases/rsync-results-to-tachash
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Vincent Ladeuil (community) Approve
Review via email: mp+248097@code.launchpad.net

Commit message

To add result and error file rsync'ing back to the jenkins master from the phone slaves.

Description of the change

To add result and error file rsync'ing back to the jenkins master from the phone slaves.

This is based on a (probably) temporary rsync destination in tachash under /var/local/boottest/ and could/ should be modified when we make the final decision.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :
review: Approve
402. By Para Siva

Review comment to make the RSYNC_DEST overridable

403. By Para Siva

Remove blank line between comment and code

Revision history for this message
Francis Ginther (fginther) wrote :

Approve, this is consistent with the results handling for adt runs, just in a different base directory. If this is not the best location, it can be revisited.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/boottest.sh'
2--- scripts/boottest.sh 2015-01-29 14:28:51 +0000
3+++ scripts/boottest.sh 2015-01-30 13:57:39 +0000
4@@ -13,6 +13,14 @@
5 # Default adt-run timeout
6 export ADT_TIMEOUT=${ADT_TIMEOUT:-600}
7
8+# XXX psivaa 20150130: This is to use /var/local/boottest
9+# directory in tachash for rsyncing the results back.
10+# This should be revisited and fixed when the actual directory
11+# is decided for final
12+# May need tweaking/ removing the boottest section of /etc/rsyncd.conf
13+# in tachash
14+export RSYNC_DEST=${RSYNC_DEST:-rsync://tachash.ubuntu-ci/boottest/}
15+
16 # If the NODE_NAME is unset, we're running locally, the commands that
17 # requires a phone are prefixed with "[ -z ${NODE_NAME} ] ||"
18 # If you have a phone available locally, set ANDROID_SERIAL and NODE_NAME=yes
19@@ -119,12 +127,12 @@
20 [ $RET -gt 0 ] && result="FAIL"
21 set +x # quiet mode as it pollutes output
22 echo "$RELEASE $ARCH $(cat results/testpkg-version) $result $(sort -u results/*-packages|tr -s '[\n\t]' ' ')" > $resultfile
23-# [ -f "$resultfile" ] && rsync -a $resultfile $RSYNC_DEST/${RELEASE}/tmp/ || true
24+ [ -f "$resultfile" ] && rsync -a $resultfile $RSYNC_DEST/${RELEASE}/tmp/ || true
25 else
26 # Something went wrong with the testbed
27 errfile=results/${RELEASE}_${ARCH}_${SRC_PKG_NAME}_$(date +%Y%m%d-%H%M%S).error
28 echo "$RELEASE $ARCH $SRC_PKG_NAME" > $errfile
29-# [ -f "$errfile" ] && rsync -a $errfile $RSYNC_DEST/${RELEASE}/tmp/ || true
30+ [ -f "$errfile" ] && rsync -a $errfile $RSYNC_DEST/${RELEASE}/tmp/ || true
31 fi
32
33 exit $RET

Subscribers

People subscribed via source and target branches