Merge lp:~psivaa/ubuntu-test-cases/per-test-timeout-autopilot-for-rtm into lp:ubuntu-test-cases/touch

Proposed by Para Siva
Status: Needs review
Proposed branch: lp:~psivaa/ubuntu-test-cases/per-test-timeout-autopilot-for-rtm
Merge into: lp:ubuntu-test-cases/touch
Diff against target: 28 lines (+7/-0)
2 files modified
scripts/run-autopilot-tests.sh (+1/-0)
utils/host/reboot-and-unlock.sh (+6/-0)
To merge this branch: bzr merge lp:~psivaa/ubuntu-test-cases/per-test-timeout-autopilot-for-rtm
Reviewer Review Type Date Requested Status
Ubuntu Test Case Developers Pending
Review via email: mp+240845@code.launchpad.net

Commit message

Install ppa version of autopilot-1.5 for the rtm images and to enable per-test timeout for all the images.

Description of the change

This is to install ppa version of autopilot-1.5 for rtm images and to enable per-test timeout. The timeout is given to be 180 seconds at the moment.

Tested with rtm (ubuntu-rtm/14.09-proposed) and vivid (devel-proposed) channels. The timeout of 3 min per test seems to be sufficient.

To post a comment you must log in.
340. By Para Siva

Format and spaces

Revision history for this message
Paul Larson (pwlars) wrote :

We don't actually seem to be having much trouble with this in RTM though do we? vivid results are still pretty incomplete, but RTM is running much better since some of the recent updates. If so, I really don't think we should hack around a problem that isn't present.

In general, I really don't like injecting a PPA into the test process, especially since we are trying to get towards a readonly, adt-run tested system.

Revision history for this message
Para Siva (psivaa) wrote :

I think we had hanging issues in rtm a little while ago and it's a matter of time before we see another one. If by chance we see that then it will be on us to rerun the missed tests due to that hang and that process is messy because we need to cherry pick the apps but the hanging one to have the rest of the results.

Also, this ppa injection is only for the rtm though, so this is not changing anything for non-rtm runs.

Unmerged revisions

340. By Para Siva

Format and spaces

339. By Para Siva

Enable autopilot/1.5 ppa for rtm images and include per test timeout

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/run-autopilot-tests.sh'
2--- scripts/run-autopilot-tests.sh 2014-10-16 14:13:12 +0000
3+++ scripts/run-autopilot-tests.sh 2014-11-06 12:41:16 +0000
4@@ -96,6 +96,7 @@
5 -a /var/crash -a /home/phablet/.cache/upstart \
6 -a /var/log/syslog \
7 -A --timeout-profile=long \
8+ -A --test-timeout=180 \
9 -v $app || true
10 adb shell rm -rf /tmp/ci-logs
11 adb shell mkdir /tmp/ci-logs
12
13=== modified file 'utils/host/reboot-and-unlock.sh'
14--- utils/host/reboot-and-unlock.sh 2014-08-21 20:18:25 +0000
15+++ utils/host/reboot-and-unlock.sh 2014-11-06 12:41:16 +0000
16@@ -3,6 +3,12 @@
17
18 basedir=$(dirname $(readlink -f $0))
19
20+# install ppa version of autopilot for rtm images
21+if adb shell system-image-cli -i | grep rtm 2>/dev/null > /dev/null ; then
22+ adb shell sudo apt-add-repository -y "deb http://ppa.launchpad.net/autopilot/1.5/ubuntu utopic main"
23+ adb shell sudo apt-get update
24+fi
25+
26 if ! adb-shell dpkg -s unity8-autopilot 2>/dev/null >/dev/null ; then
27 echo "Installing unity8-autopilot as a pre-req for unlocking screen"
28 adb shell sudo apt-get install -yq --force-yes unity8-autopilot

Subscribers

People subscribed via source and target branches