Merge lp:~psivaa/ubuntu-test-cases/mod_php-fix into lp:ubuntu-test-cases/server
Proposed by
Para Siva
on 2014-01-31
Status: | Merged |
---|---|
Merged at revision: | 96 |
Proposed branch: | lp:~psivaa/ubuntu-test-cases/mod_php-fix |
Merge into: | lp:ubuntu-test-cases/server |
Diff against target: |
40 lines (+4/-4) 3 files modified
testsuites/lamp/test_mod_php/test.py (+1/-1) testsuites/lamp/test_mysql_select_from_users/test.py (+1/-1) testsuites/lamp/test_mysql_show_databases/test.py (+2/-2) |
To merge this branch: | bzr merge lp:~psivaa/ubuntu-test-cases/mod_php-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robie Basak | 2014-01-31 | Approve on 2014-02-25 | |
Review via email:
|
To post a comment you must log in.
lp:~psivaa/ubuntu-test-cases/mod_php-fix
updated
on 2014-02-24
Para Siva (psivaa) wrote : | # |
I've made some changes to the mysql tests after the changes for mysql-5.5 on 5.5.35+
Robie Basak (racb) wrote : | # |
This is certainly no worse than it was before. Please also change the comment from 7 to 5 - otherwise the comment will mismatch the code.
A suggest for improvement here (but I don't wish for this to block merging this branch now): I'd say that we should check the return value of the mysql command, since that is the conventional programmatic way for it to declare that there was a problem. subprocess.Popen provides a mechanism to do this.
review:
Approve
lgtm. I know that Apache in Debian (and now Trusty) has this changed path. Thanks!