Ubuntu Test Cases

Merge lp:~psivaa/ubuntu-test-cases/disable-memory-change-healthcheck-nm into lp:~ubuntu-test-case-dev/ubuntu-test-cases/health-check

  1. disable-memory-change-healthcheck-nm
  2. Merge into health-check
Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 19
Merged at revision: 16
Proposed branch: lp:~psivaa/ubuntu-test-cases/disable-memory-change-healthcheck-nm
Merge into: lp:~ubuntu-test-case-dev/ubuntu-test-cases/health-check
Diff against target: 16 lines (+5/-1)
1 file modified
thresholds/i686/NetworkManager.threshold (+5/-1)
To merge this branch: bzr merge lp:~psivaa/ubuntu-test-cases/disable-memory-change-healthcheck-nm
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+271623@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Just a date format nit.

review: Approve
lp:~psivaa/ubuntu-test-cases/disable-memory-change-healthcheck-nm updated
19. By Para Siva

Date format is YYYYMMDD in the comment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'thresholds/i686/NetworkManager.threshold'
2--- thresholds/i686/NetworkManager.threshold 2014-01-31 15:01:45 +0000
3+++ thresholds/i686/NetworkManager.threshold 2015-09-21 16:21:22 +0000
4@@ -65,7 +65,11 @@
5 #
6 # health-check.memory-change.memory-change-total.
7 health-check.heap-usage-via-brk.heap-usage-via-brk-total.brk-size-total-Kbytes-rate 0.002777778
8-health-check.memory-usage-via-mmap.memory-usage-via-mmap-total.mmap-total-Kbytes-rate 0.002777778
9+# XXX psivaa: 20150921: NetworkManager mmaps 64Mb when a new connection occurs
10+# This is equivalent to 32.28Kb per second rate over
11+# a 1800 second (30 minute) run of heath-check
12+# Commenting the following threshold until bug 1497996 is fixed
13+# health-check.memory-usage-via-mmap.memory-usage-via-mmap-total.mmap-total-Kbytes-rate 0.002777778
14 #
15 # Network, should be fairly idle
16 #

Subscribers

People subscribed via source and target branches