Merge lp:~psivaa/ubuntu-ci-services-itself/reduce-ppa-retry-period into lp:ubuntu-ci-services-itself

Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 388
Merged at revision: 390
Proposed branch: lp:~psivaa/ubuntu-ci-services-itself/reduce-ppa-retry-period
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 12 lines (+1/-1)
1 file modified
lander/bin/lander_service_wrapper.py (+1/-1)
To merge this branch: bzr merge lp:~psivaa/ubuntu-ci-services-itself/reduce-ppa-retry-period
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211013@code.launchpad.net

Commit message

The ppa assigner retries of 2 min seems a little longer when the ppa becomes free during runs . This does not matter in cases when ppa is free right at the start of a run but would be useful when ppa was not free at the start and then becomes available during the run.

Description of the change

The ppa assigner retries of 2 min seems a little longer when the ppa becomes free during runs . This does not matter in cases when ppa is free right at the start of a run but would be useful when ppa was not free at the start and then becomes available during the run.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:388
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/421/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/421/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

NOTE: I don't think this will be a problem outside of developer-testing. We only do one ticket at a time, so needing lots of ppas and polling them constantly doesn't seem likely.

review: Approve
Revision history for this message
Para Siva (psivaa) wrote :

Thanks. I was thinking this could be an issue when consecutive tickets failed probably in a quick succession in a post ppa assigning stage, leaving no free ppa's in the pool whilst the user triggers the next ticket. The webui not updating whilst waiting for ppa's would not help the user a lot and I think the time this saving could be useful there. Could be wrong.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lander/bin/lander_service_wrapper.py'
2--- lander/bin/lander_service_wrapper.py 2014-03-13 23:11:50 +0000
3+++ lander/bin/lander_service_wrapper.py 2014-03-14 10:17:17 +0000
4@@ -136,7 +136,7 @@
5
6
7 def _get_ppa(ppa_assigner_url, ticket_id):
8- timeout = 120
9+ timeout = 15
10 url = '%s/api/v1/ppa/' % ppa_assigner_url
11 while True:
12 try:

Subscribers

People subscribed via source and target branches