Merge lp:~psivaa/qa-iso-static-validation-test/vmlinuz_fix_for_amd64 into lp:qa-iso-static-validation-test

Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 22
Merged at revision: 22
Proposed branch: lp:~psivaa/qa-iso-static-validation-test/vmlinuz_fix_for_amd64
Merge into: lp:qa-iso-static-validation-test
Diff against target: 30 lines (+10/-4)
1 file modified
iso_static_validation.py (+10/-4)
To merge this branch: bzr merge lp:~psivaa/qa-iso-static-validation-test/vmlinuz_fix_for_amd64
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+138232@code.launchpad.net

Description of the change

vmlinuz renaming on amd64 images are adopted on test_vmlinuz test.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'iso_static_validation.py'
2--- iso_static_validation.py 2012-11-29 16:54:39 +0000
3+++ iso_static_validation.py 2012-12-05 15:56:41 +0000
4@@ -316,16 +316,22 @@
5 def test_vmlinuz(self):
6 if(self.ubiquity_image == False or self.st_arch == 'powerpc'):
7 self.skipTest("vmlinuz is present only for ubiquity based images")
8- cmd = ["bsdtar", "-xf", self.iso_location, "-C",
9- self.temp_dir, "casper/vmlinuz"]
10+ kernel_name = "casper/vmlinuz"
11+
12+ if self.st_arch == 'amd64':
13+ kernel_name = "casper/vmlinuz.efi"
14+
15+ cmd = ["bsdtar", "-xf", self.iso_location, "-C",
16+ self.temp_dir, kernel_name]
17+
18 output = subprocess.Popen(cmd, stdout=subprocess.PIPE,
19 stderr=subprocess.PIPE)
20 (stdout, stderr) = output.communicate()
21 logging.debug('Asserting that vmlinuz is present in the iso')
22 self.assertEqual(stderr, '')
23
24- vmlinuz_path = os.path.join(self.temp_dir, 'casper/vmlinuz')
25-
26+ vmlinuz_path = os.path.join(self.temp_dir, kernel_name)
27+
28 cmd = ["file", vmlinuz_path]
29 output = subprocess.Popen(cmd, stdout=subprocess.PIPE,
30 stderr=subprocess.PIPE)

Subscribers

People subscribed via source and target branches

to all changes: