jenkins-launchpad-plugin

Merge lp:~psivaa/jenkins-launchpad-plugin/update-branch-class into lp:jenkins-launchpad-plugin

  1. update-branch-class
  2. Merge into trunk
Proposed by Para Siva
Status: Merged
Approved by: Para Siva
Approved revision: 125
Merged at revision: 125
Proposed branch: lp:~psivaa/jenkins-launchpad-plugin/update-branch-class
Merge into: lp:jenkins-launchpad-plugin
Diff against target: 13 lines (+2/-1)
1 file modified
jlp/branch.py (+2/-1)
To merge this branch: bzr merge lp:~psivaa/jenkins-launchpad-plugin/update-branch-class
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Joe Talbott (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+272226@code.launchpad.net

Commit message

Fix jlp Branch class to have the same footprint as the base class, Branch from tarmac

Description of the change

Fix jlp Branch class to have the same footprint as the base class, Branch from tarmac

Guidance from:
https://trello.com/c/2nSVbntH/563-jenkins-lp-plugin-spike-update-jlp-branch-py-to-match-tarmac-0-5

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:125
http://jenkins.qa.ubuntu.com/job/jenkins-launchpad-plugin-ci/42/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/jenkins-launchpad-plugin-trusty-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/jenkins-launchpad-plugin-trusty-i386-ci/7

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/jenkins-launchpad-plugin-ci/42/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jlp/branch.py'
2--- jlp/branch.py 2013-05-10 16:09:40 +0000
3+++ jlp/branch.py 2015-09-24 10:47:21 +0000
4@@ -8,7 +8,8 @@
5
6
7 class Branch(TarmacBranch):
8- def __init__(self, lp_branch, config=False, target=None):
9+ def __init__(self, lp_branch, config=False, target=None, launchpad=None):
10+ super(Branch, self).__init__(lp_branch, config, target, launchpad)
11 self.lp_branch = lp_branch
12 self.branch_url = ('bzr+ssh://' +
13 get_config_option('launchpad_login') +

Subscribers

People subscribed via source and target branches

to all changes: