Merge lp:~psivaa/core-selftest-agent/add-test-branch-conf into lp:core-selftest-agent

Proposed by Para Siva
Status: Needs review
Proposed branch: lp:~psivaa/core-selftest-agent/add-test-branch-conf
Merge into: lp:core-selftest-agent
Diff against target: 73 lines (+29/-0)
3 files modified
core-service.conf (+12/-0)
core_selftest_agent/__init__.py (+15/-0)
core_selftest_agent/worker.py (+2/-0)
To merge this branch: bzr merge lp:~psivaa/core-selftest-agent/add-test-branch-conf
Reviewer Review Type Date Requested Status
Canonical CI Engineering Pending
Review via email: mp+260205@code.launchpad.net

Commit message

Adding test_branch config option to the agent.

Description of the change

Adding test_branch config option to the agent.

To post a comment you must log in.

Unmerged revisions

8. By Para Siva

pep8 and pyflakes

7. By Para Siva

Adding test_branch as config parameter

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'core-service.conf'
2--- core-service.conf 1970-01-01 00:00:00 +0000
3+++ core-service.conf 2015-05-26 19:15:37 +0000
4@@ -0,0 +1,12 @@
5+[amqp]
6+uris = amqp://guest:guest@localhost:5672//
7+
8+[nova]
9+os_username = foo
10+os_password = <redacted>
11+os_tenant_name = foo_project
12+os_auth_url = http://172.20.161.138:5000/v2.0/
13+
14+[snappy]
15+test_branch = lp:snappy/selftest
16+
17
18=== modified file 'core_selftest_agent/__init__.py'
19--- core_selftest_agent/__init__.py 2015-05-22 19:49:10 +0000
20+++ core_selftest_agent/__init__.py 2015-05-26 19:15:37 +0000
21@@ -29,6 +29,7 @@
22 from core_selftest_agent import constants
23 from core_selftest_agent.worker import CoreSelftestAgentWorker
24
25+logger = get_logger(__name__)
26
27 class CoreImageResultPublisher(object):
28 """A callable that can notify a results exchange that the test is running
29@@ -45,6 +46,7 @@
30
31 def __call__(self, payload):
32 """Take 'payload' and enqueue it on the rabbit exchange."""
33+ check_payload(payload)
34 queue = self.connection.SimpleQueue(self.queue)
35 queue.put(payload)
36 queue.close()
37@@ -62,11 +64,24 @@
38
39 def __call__(self, payload):
40 """Take 'payload' and enqueue it on the rabbit queue."""
41+ check_payload(payload)
42 queue = self.connection.SimpleQueue(constants.IMAGE_BUILD_QUEUE)
43 queue.put(payload)
44 queue.close()
45
46
47+def check_payload(payload):
48+ extra = constants.LOGGING_EXTRA.copy()
49+ extra.update(payload)
50+ try:
51+ nova_image_id = payload['source_name']
52+ image_name = payload['source_version']
53+ device = payload['series']
54+ test_branch = payload['test_branch']
55+ except KeyError as e:
56+ logger.error("Message does not contain required ", extra=extra)
57+
58+
59 def read_config():
60 parser = argparse.ArgumentParser(description='Core Selftest Agent.')
61 parser.add_argument(
62
63=== modified file 'core_selftest_agent/worker.py'
64--- core_selftest_agent/worker.py 2015-05-22 19:49:10 +0000
65+++ core_selftest_agent/worker.py 2015-05-26 19:15:37 +0000
66@@ -48,5 +48,7 @@
67 For now, just blindly post messages for these
68 """
69
70+ test_branch = self.config['snappy']['test_branch']
71+ body['test_branch'] = test_branch
72 self.build_worker(body)
73 self.result_worker(body)

Subscribers

People subscribed via source and target branches