Code review comment for lp:~psivaa/charms/trusty/jenkaas/install-jenkins

Revision history for this message
Francis Ginther (fginther) wrote :

I'd leave the charm name as 'jenkaas' (the one specified in the metafile) and also matches the trunk name. This charm is specific to our deployment and not a general purpose jenkins charm, so it makes sense to me to use a unique name.

Otherwise, looks good.

review: Needs Fixing

« Back to merge proposal