Merge lp:~psivaa/auto-package-testing/separate-boottest-datadir-creds into lp:~canonical-ci-engineering/auto-package-testing/add-boottest-requests

Proposed by Para Siva
Status: Merged
Merged at revision: 402
Proposed branch: lp:~psivaa/auto-package-testing/separate-boottest-datadir-creds
Merge into: lp:~canonical-ci-engineering/auto-package-testing/add-boottest-requests
Diff against target: 28 lines (+11/-2)
2 files modified
etc/boottest-britney.rc (+9/-0)
jenkins/run-boottest-jenkins.py (+2/-2)
To merge this branch: bzr merge lp:~psivaa/auto-package-testing/separate-boottest-datadir-creds
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Paul Larson Approve
Joe Talbott (community) Needs Information
Review via email: mp+250004@code.launchpad.net

Commit message

Use different datadir and credentials for boottesting even when deployed along with adt

Description of the change

This is to use different credentials and rc file for boottest requests even when boottesting is deployed along with adt.

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

One in-line question.

review: Needs Information
Revision history for this message
Paul Larson (pwlars) wrote :

I guess we have to do this because they don't want credentials to overlap? Is this just a temporary thing? I don't know the back story on this completely, but the change looks ok.

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

Same question as Joe, worth replying by a comment in the file itself ;-)

403. By Para Siva

Comment about using the QA - adt apt cache

Revision history for this message
Para Siva (psivaa) wrote :

@Joe, replied inline. Basically it's intentional to have the same cache after production deployment.

@Paul: Yea the credentials used for adt has some issues with it. Although we could use the same adt creds after fixing them. The rationale for not going on that path is that at the moment we're not responsible for that deployment.

Revision history for this message
Vincent Ladeuil (vila) wrote :

<psivaa> vila: yea, we're going to use the same apt cache. i've added a comment to that effect

<psivaa> vila: i'm saying that we *can share the credentials and also have our own creds for that.. datadir has to be different as you pointed out earlier

Ack

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'etc/boottest-britney.rc'
2--- etc/boottest-britney.rc 1970-01-01 00:00:00 +0000
3+++ etc/boottest-britney.rc 2015-02-17 14:45:24 +0000
4@@ -0,0 +1,9 @@
5+# Default configuration file for adt-britney
6+# This file should be placed under
7+# /var/lib/jenkins/CI/
8+# But using the adt apt cache in order to avoid
9+# the disk filling up
10+aptroot: /var/lib/jenkins/QA/adt/aptroot
11+apturi: http://ftpmaster.internal/ubuntu/
12+components: main restricted universe multiverse
13+datadir: /var/local/boottest/
14
15=== modified file 'jenkins/run-boottest-jenkins.py'
16--- jenkins/run-boottest-jenkins.py 2015-02-16 10:14:40 +0000
17+++ jenkins/run-boottest-jenkins.py 2015-02-17 14:45:24 +0000
18@@ -55,8 +55,8 @@
19 cmd = ['python',
20 os.path.join(CWD, 'adt-jenkins'),
21 '-dbP',
22- '-c', os.path.expanduser('~/QA/adt-britney.rc'),
23- '-J', os.path.expanduser('~/.adt.credentials'),
24+ '-c', os.path.expanduser('~/CI/boottest-britney.rc'),
25+ '-J', os.path.expanduser('~/.boottest.credentials'),
26 '-r', release,
27 '--submit', statefile]
28 proc = subprocess.Popen(cmd, stdout=subprocess.PIPE,

Subscribers

People subscribed via source and target branches