Auto Package Testing

Merge lp:~psivaa/auto-package-testing/console-cleaning into lp:~canonical-ci-engineering/auto-package-testing/adt-nova-support

  1. console-cleaning
  2. Merge into adt-nova-support
Proposed by Para Siva
Status: Needs review
Proposed branch: lp:~psivaa/auto-package-testing/console-cleaning
Merge into: lp:~canonical-ci-engineering/auto-package-testing/adt-nova-support
Diff against target: 28 lines (+3/-3)
1 file modified
jenkins/run-nova-autopkgtest (+3/-3)
To merge this branch: bzr merge lp:~psivaa/auto-package-testing/console-cleaning
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Paul Larson Needs Information
Review via email: mp+253803@code.launchpad.net

Commit message

Console log cleaning. Suppresses curl progress output.

Description of the change

Console log cleaning. Suppresses curl progress output.

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

Have you also explored using curl -s instead? I worry that we might unintentionally hide an error by doing this, and -s should eliminate the transfer stats we currently see in the log.

review: Needs Information
Reply
lp:~psivaa/auto-package-testing/console-cleaning updated
411. By Para Siva

Use -sS to suppress the progress bar and show error

Revision history for this message
Para Siva (psivaa) wrote :

Thanks for the valid point Paul. I have now used -sS since I saw some posts complaining about -s alone not working in some versions of curl.

Could you check again please?

Reply
Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve
Reply

Unmerged revisions

411. By Para Siva

Use -sS to suppress the progress bar and show error

410. By Para Siva

Less uglier console output for nova adt runs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jenkins/run-nova-autopkgtest'
2--- jenkins/run-nova-autopkgtest 2015-03-20 05:49:47 +0000
3+++ jenkins/run-nova-autopkgtest 2015-03-24 09:11:32 +0000
4@@ -18,13 +18,13 @@
5 DEVEL_RELEASE=$(distro-info -d)
6
7 if [ $RELEASE != $DEVEL_RELEASE ]; then
8- RESPONSE=$(curl --data package-name="$PACKAGE" \
9+ RESPONSE=$(curl -sS --data package-name="$PACKAGE" \
10 --data architecture="$ARCH" \
11 --data platform="nova" \
12 --data series="$RELEASE"
13 --data apt-pocket="proposed" $SERVICE_URL)
14 else
15- RESPONSE=$(curl --data package-name="$PACKAGE" \
16+ RESPONSE=$(curl -sS --data package-name="$PACKAGE" \
17 --data architecture="$ARCH" \
18 --data platform="nova" \
19 --data series="$RELEASE" $SERVICE_URL)
20@@ -41,7 +41,7 @@
21 UNAUTHORIZED=Unauthorized
22 echo "I: Searching for result tarball at: ${RESULT_URL}"
23 while [ $COUNT -lt $RETRY_COUNT ]; do
24- RESULT_IN=$(curl -I $RESULT_URL)
25+ RESULT_IN=$(curl -sS -I $RESULT_URL)
26 if [ ! "${RESULT_IN#*$UNAUTHORIZED}" != "$RESULT_IN" ]; then
27 echo "I: The result tarball is available in swift"
28 COUNT=`expr $RETRY_COUNT + 1`

Subscribers

People subscribed via source and target branches