Merge ~przemeklal/charm-juju-lint:fix-lp-1970753 into charm-juju-lint:master

Proposed by Przemyslaw Lal
Status: Merged
Approved by: Xav Paice
Approved revision: 8f8ec04a80aa40f07e33755d03b3d529e7c6e81e
Merged at revision: 0197b12c0fe42ffe2efd6b50e6f683214d0b0d05
Proposed branch: ~przemeklal/charm-juju-lint:fix-lp-1970753
Merge into: charm-juju-lint:master
Diff against target: 19 lines (+3/-3)
1 file modified
lib/lib_jujulint.py (+3/-3)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+420741@code.launchpad.net

Commit message

Rewrite auto_lint.py when creating it from the template

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 0197b12c0fe42ffe2efd6b50e6f683214d0b0d05

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lib_jujulint.py b/lib/lib_jujulint.py
2index 872507b..0085aee 100644
3--- a/lib/lib_jujulint.py
4+++ b/lib/lib_jujulint.py
5@@ -92,11 +92,11 @@ class JujuLintHelper:
6 "REPLACE_CHARMDIR", str(charm_dir)
7 )
8
9- fd = os.open(str(Paths.AUTO_LINT_SCRIPT_PATH), os.O_CREAT | os.O_WRONLY, 0o755)
10-
11- with open(fd, "w") as f:
12+ with open(str(Paths.AUTO_LINT_SCRIPT_PATH), "w+") as f:
13 f.write(auto_lint_script)
14
15+ os.chmod(str(Paths.AUTO_LINT_SCRIPT_PATH), 0o755)
16+
17 # install all files in scripts/plugins/ into nagios plugins dir
18 plugins_dir = scripts_dir / "plugins"
19 # Note that we need to add 'options' here to remove the flag '--delete' that

Subscribers

People subscribed via source and target branches

to all changes: