Merge lp:~prysdieheer/ubuntu-za/menu-revisions2 into lp:ubuntu-za
Proposed by
Ashton van Niekerk
on 2015-04-09
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~prysdieheer/ubuntu-za/menu-revisions2 |
| Merge into: | lp:ubuntu-za |
| Diff against target: |
407 lines (+190/-164) 6 files modified
conf.py (+24/-14) pages/get-involved.rst (+93/-0) pages/get-started.rst (+57/-0) pages/getting-involved.rst (+0/-93) pages/getting-started.rst (+0/-57) themes/ubuntuza/assets/css/theme.css (+16/-0) |
| To merge this branch: | bzr merge lp:~prysdieheer/ubuntu-za/menu-revisions2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raoul Snyman | 2015-04-09 | Needs Fixing on 2015-04-09 | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-04-08.
This proposal has been superseded by a proposal from 2015-04-09.
Description of the Change
Did the changes superfly asked for. Had to make a new branch, because I got some message I did not understand with the old one.
To post a comment you must log in.
lp:~prysdieheer/ubuntu-za/menu-revisions2
updated
on 2015-04-09
- 28. By Ashton van Niekerk on 2015-04-09
-
Fixed the footer, still prefer it in the middle though.
Unmerged revisions
- 28. By Ashton van Niekerk on 2015-04-09
-
Fixed the footer, still prefer it in the middle though.
- 27. By Ashton van Niekerk on 2015-04-09
-
Changesd 'getting' to 'get' in the menu and titles.
- 26. By Ashton van Niekerk on 2015-04-08
-
Put the social links at both top and footer, and placed it in the conf file footer variable


You're doing the footer wrong, and messing it up. It's already in a <p> tag, remove yours. Also, we're using HTML5, no need for / in your <br> tags. HTML != XML
CONTENT_FOOTER = ''' getnikola. com" rel="nofollow" >Nikola< /a> | /twitter. com/ubuntuza" style=" text-allign: right;" target= "_blank" ><span class="fa fa-twitter fa-fw" ></span>Twitter</a> | /www.facebook. com/groups/ ubuntuza/" target= "_blank" ><span class="fa fa-facebook fa-fw"></span> Facebook</a> | /plus.google. com/+Ubuntu- zaOrg" target= "_blank" ><span class="fa fa-google-plus fa-fw"></span> Google+</a>
Contents © {date} {author} - Powered by <a href="http://
<a href="https:/
<a href="https:/
<a href="https:/
| {license}'''