Fix #2171: vm_start: volid based statefiles were not activated
So, while we could just make this a special case before the
config_to_command call and set the $conf->{vmstate} to the statefile
for the case were it's a valid volumeid, the special case handling
get's much easier when we do this outside of that method.
So it's basically a trade-off, and after looking far to long at all
nice revisions Alwin made for me and Fabians request, and even trying
out different approaches, it was never perfect.
But having slight code duplication over the movement mess I proposed
(as I did not had the full picture then, sorry Alwin) felt like the
slightly nicer trade off, as all worked I just use this one now, it
has very clear semantics, easy to understand and that now three lines
are duplicated is IMO irrelevant.
Co-developed-by: Alwin Antreich <email address hidden>
Signed-off-by: Thomas Lamprecht <email address hidden>
(cherry picked from commit 5c1d42b7f825fa124ff3701b32f9ecc011bece95)
[squashed the two fixups from master into this one]
Signed-off-by: Thomas Lamprecht <email address hidden>
close #2263: die on live migration with local cloudinit disk
Live migration with a local cloudinit disk was never intended to work. It did
however work to an extent that the migration completed but the disk on the
source node could not be deleted. Now die if a live migration is started with
a local cloudinit disk.
With the GUI changes live migration is already disabled as it recognizes the
cloudinit disk as a local resource.
Signed-off-by: Mira Limbeck <email address hidden>
(cherry picked from commit 9860fe4ef992e8550f8dee9aed65e2fed75c470f)
Signed-off-by: Oguz Bektas <email address hidden>
54a012f...
by
Alwin Antreich <email address hidden>
fix: qemu: uninitialized value in multiplication
A generated VM with default values does not set the memory key in the
configuration. Hence the size of the state file for a suspend had only
the default size of the state itself and not in addition twice the
configured memory.
The patch uses the static defaults from the JSON schema if the memory
key is not set.
Signed-off-by: Alwin Antreich <email address hidden>
(cherry picked from commit 22ea69ca65b14bf0caf64dd0daf5c6bff675edf8)
Signed-off-by: Oguz Bektas <email address hidden>
1c4de34...
by
Dominik Csapak <email address hidden>
fix #2275: die on invalid sendkey
sendkey does not return anything if it is succesful and the error otherwise
Signed-off-by: Dominik Csapak <email address hidden>
(cherry picked from commit d30820d6c382a3c0c1979b33f2f5177900735ade)
Signed-off-by: Oguz Bektas <email address hidden>
