Merge lp:~project-calico/charm-helpers/liberty2 into lp:charm-helpers

Proposed by Nell Jerram
Status: Needs review
Proposed branch: lp:~project-calico/charm-helpers/liberty2
Merge into: lp:charm-helpers
Diff against target: 39 lines (+15/-9)
1 file modified
charmhelpers/contrib/openstack/neutron.py (+15/-9)
To merge this branch: bzr merge lp:~project-calico/charm-helpers/liberty2
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+288382@code.launchpad.net

Description of the change

Add support for Calico networking with OpenStack Liberty release.

Specifically, with Liberty we use a Calico-specific DHCP agent instead of the Neutron reference DHCP agent. Therefore we install an additional package, calico-dhcp-agent, and manage the 'calico-dhcp-agent' service instead of 'neutron-dhcp-agent'.

To post a comment you must log in.
Revision history for this message
Nell Jerram (neil-jerram) wrote :

This merge request replaces https://code.launchpad.net/~project-calico/charm-helpers/liberty/+merge/287927, because that one had conflicts.

Unmerged revisions

539. By Nell Jerram

Changes for Calico networking with OpenStack Liberty

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/openstack/neutron.py'
2--- charmhelpers/contrib/openstack/neutron.py 2016-03-01 20:08:54 +0000
3+++ charmhelpers/contrib/openstack/neutron.py 2016-03-08 09:59:13 +0000
4@@ -171,15 +171,13 @@
5 ssl_dir=NEUTRON_CONF_DIR)],
6 'services': ['calico-felix',
7 'bird',
8- 'neutron-dhcp-agent',
9- 'nova-api-metadata',
10- 'etcd'],
11- 'packages': [determine_dkms_package(),
12- ['calico-compute',
13- 'bird',
14- 'neutron-dhcp-agent',
15- 'nova-api-metadata',
16- 'etcd']],
17+ 'calico-dhcp-agent',
18+ 'nova-api-metadata',
19+ 'etcd'],
20+ 'packages': ['calico-compute',
21+ 'calico-dhcp-agent',
22+ 'nova-api-metadata',
23+ 'etcd'],
24 'server_packages': ['neutron-server', 'calico-control', 'etcd'],
25 'server_services': ['neutron-server', 'etcd']
26 },
27@@ -247,6 +245,14 @@
28 'networking_plumgrid.neutron.plugins.plugin.NeutronPluginPLUMgridV2')
29 plugins['plumgrid']['server_packages'].remove(
30 'neutron-plugin-plumgrid')
31+
32+ # For Calico pre-Liberty, use Neutron DHCP agent instead of Calico DHCP
33+ # agent.
34+ if release < 'liberty':
35+ plugins['Calico']['packages'].remove('calico-dhcp-agent')
36+ plugins['Calico']['services'].remove('calico-dhcp-agent')
37+ plugins['Calico']['services'].append('neutron-dhcp-agent')
38+
39 return plugins
40
41

Subscribers

People subscribed via source and target branches