Merge lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4 into lp:ubuntu/vivid/unity-greeter-badges

Proposed by Doug Torrance
Status: Approved
Approved by: Graham Inggs
Approved revision: 4
Proposed branch: lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4
Merge into: lp:ubuntu/vivid/unity-greeter-badges
Diff against target: 170 lines (+47/-62)
4 files modified
debian/changelog (+17/-0)
debian/control (+1/-1)
debian/install (+2/-61)
debian/rules (+27/-0)
To merge this branch: bzr merge lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4
Reviewer Review Type Date Requested Status
Graham Inggs Approve
Review via email: mp+251365@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Graham Inggs (ginggs) :
review: Approve

Unmerged revisions

4. By Doug Torrance

* New upstream release.
* debian/install
  - Simplify file to use wildcard. We will handle the special cases
    in debian/rules.
  - Remove executable bit; not needed since we no longer use dh-exec.
* debian/control
  - Remove dh-exec from Build-Depends; no longer needed.
* debian/rules
  - Add override_dh_install target to remove badges found in other packages
    and fix resulting broken symlinks. This function was previously
    performed by dh-exec using debian/install, but this was harder to
    maintain.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added symlink 'custom_QLubuntu_badge.png'
2=== target is u'custom_LXDE_badge.png'
3=== added file 'custom_aewm++_badge.png'
4Binary files custom_aewm++_badge.png 1970-01-01 00:00:00 +0000 and custom_aewm++_badge.png 2015-02-28 14:28:23 +0000 differ
5=== added file 'custom_cde_badge.png'
6Binary files custom_cde_badge.png 1970-01-01 00:00:00 +0000 and custom_cde_badge.png 2015-02-28 14:28:23 +0000 differ
7=== added file 'custom_deepin_badge.png'
8Binary files custom_deepin_badge.png 1970-01-01 00:00:00 +0000 and custom_deepin_badge.png 2015-02-28 14:28:23 +0000 differ
9=== added file 'custom_ede_badge.png'
10Binary files custom_ede_badge.png 1970-01-01 00:00:00 +0000 and custom_ede_badge.png 2015-02-28 14:28:23 +0000 differ
11=== added file 'custom_gnome-bluetile_badge.png'
12Binary files custom_gnome-bluetile_badge.png 1970-01-01 00:00:00 +0000 and custom_gnome-bluetile_badge.png 2015-02-28 14:28:23 +0000 differ
13=== added symlink 'custom_lubuntu-nexus7_badge.png'
14=== target is u'custom_LXDE_badge.png'
15=== added symlink 'custom_lxgames_badge.png'
16=== target is u'custom_LXDE_badge.png'
17=== added file 'custom_matchbox_badge.png'
18Binary files custom_matchbox_badge.png 1970-01-01 00:00:00 +0000 and custom_matchbox_badge.png 2015-02-28 14:28:23 +0000 differ
19=== added file 'custom_mate-old_badge.png'
20Binary files custom_mate-old_badge.png 1970-01-01 00:00:00 +0000 and custom_mate-old_badge.png 2015-02-28 14:28:23 +0000 differ
21=== modified file 'custom_mate_badge.png'
22Binary files custom_mate_badge.png 2014-11-27 01:01:37 +0000 and custom_mate_badge.png 2015-02-28 14:28:23 +0000 differ
23=== added symlink 'custom_sugar-session-0.96_badge.png'
24=== target is u'custom_usr_badge.png'
25=== added symlink 'custom_sugar-session-0.98_badge.png'
26=== target is u'custom_usr_badge.png'
27=== modified file 'debian/changelog'
28--- debian/changelog 2015-01-18 12:53:25 +0000
29+++ debian/changelog 2015-02-28 14:28:23 +0000
30@@ -1,3 +1,20 @@
31+unity-greeter-badges (0.4-0ubuntu1) vivid; urgency=medium
32+
33+ * New upstream release.
34+ * debian/install
35+ - Simplify file to use wildcard. We will handle the special cases
36+ in debian/rules.
37+ - Remove executable bit; not needed since we no longer use dh-exec.
38+ * debian/control
39+ - Remove dh-exec from Build-Depends; no longer needed.
40+ * debian/rules
41+ - Add override_dh_install target to remove badges found in other packages
42+ and fix resulting broken symlinks. This function was previously
43+ performed by dh-exec using debian/install, but this was harder to
44+ maintain.
45+
46+ -- Doug Torrance <dtorrance@monmouthcollege.edu> Sat, 28 Feb 2015 07:30:52 -0600
47+
48 unity-greeter-badges (0.3-0ubuntu1) vivid; urgency=medium
49
50 * New upstream release.
51
52=== modified file 'debian/control'
53--- debian/control 2015-01-18 12:53:25 +0000
54+++ debian/control 2015-02-28 14:28:23 +0000
55@@ -3,7 +3,7 @@
56 Priority: optional
57 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
58 XSBC-Original-Maintainer: Doug Torrance <dtorrance@monmouthcollege.edu>
59-Build-Depends: debhelper (>= 9), dh-exec
60+Build-Depends: debhelper (>= 9)
61 Standards-Version: 3.9.6
62 Homepage: http://gnome-look.org/content/show.php/?content=158764
63 Vcs-Git: https://github.com/d-torrance/unity-greeter-badges.git
64
65=== modified file 'debian/install' (properties changed: +x to -x)
66--- debian/install 2015-01-18 12:53:25 +0000
67+++ debian/install 2015-02-28 14:28:23 +0000
68@@ -1,61 +1,2 @@
69-#!/usr/bin/dh-exec
70-# Some badges are already provided by packages in Ubuntu -- these are not
71-# installed. There are a few badges not provided in other packages which
72-# link to them. We rename them instead.
73-custom_afterstep_badge.png usr/share/unity-greeter
74-custom_amiwm_badge.png usr/share/unity-greeter
75-custom_awesome_badge.png usr/share/unity-greeter
76-custom_blackbox_badge.png usr/share/unity-greeter
77-# custom_cairo-dock_badge.png provided by cairo-dock-data
78-custom_cairo-dock_badge.png => usr/share/unity-greeter/custom_cairo-dock-fallback_badge.png
79-custom_cairo-dock_badge.png => usr/share/unity-greeter/custom_cairo-dock-unity_badge.png
80-custom_chromium_badge.png usr/share/unity-greeter
81-custom_cinnamon_badge.png usr/share/unity-greeter
82-custom_cinnamon2d_badge.png usr/share/unity-greeter
83-custom_dwm_badge.png usr/share/unity-greeter
84-custom_enlightenment_badge.png usr/share/unity-greeter
85-custom_etoile_badge.png usr/share/unity-greeter
86-custom_evilwm_badge.png usr/share/unity-greeter
87-custom_fluxbox_badge.png usr/share/unity-greeter
88-custom_fvwm1_badge.png usr/share/unity-greeter
89-custom_fvwm_badge.png usr/share/unity-greeter
90-custom_fvwm-crystal_badge.png usr/share/unity-greeter
91-custom_gnome-xmonad_badge.png usr/share/unity-greeter
92-custom_gnustep_badge.png usr/share/unity-greeter
93-custom_herbstluftwm_badge.png usr/share/unity-greeter
94-custom_i3_badge.png usr/share/unity-greeter
95-custom_IceWM_badge.png usr/share/unity-greeter
96-custom_IceWM-Experimental_badge.png usr/share/unity-greeter
97-custom_IceWM-Lite_badge.png usr/share/unity-greeter
98-custom_icewm-session_badge.png usr/share/unity-greeter
99-custom_larswm_badge.png usr/share/unity-greeter
100-# custom_Lubuntu_badge.png and custom_LXDE_badge.png provided by lubuntu-artwork
101-custom_LXDE_badge.png => usr/share/unity-greeter/custom_Lubuntu-Netbook_badge
102-custom_mate_badge.png usr/share/unity-greeter
103-custom_mythbuntu_badge.png usr/share/unity-greeter
104-custom_openbox_badge.png usr/share/unity-greeter
105-custom_openbox-gnome_badge.png usr/share/unity-greeter
106-custom_openbox-kde_badge.png usr/share/unity-greeter
107-custom_openbsd-cwm_badge.png usr/share/unity-greeter
108-custom_pantheon_badge.png usr/share/unity-greeter
109-custom_pekwm_badge.png usr/share/unity-greeter
110-custom_ratpoison_badge.png usr/share/unity-greeter
111-custom_razor_badge.png usr/share/unity-greeter
112-custom_sawfish_badge.png usr/share/unity-greeter
113-custom_stumpwm_badge.png usr/share/unity-greeter
114-custom_subtle_badge.png usr/share/unity-greeter
115-custom_sugar-session-0.84_badge.png usr/share/unity-greeter
116-custom_sugar-session-0.86_badge.png usr/share/unity-greeter
117-custom_sugar-session-0.88_badge.png usr/share/unity-greeter
118-custom_sugar-session-0.90_badge.png usr/share/unity-greeter
119-custom_trinity_badge.png usr/share/unity-greeter
120-custom_twm_badge.png usr/share/unity-greeter
121-custom_ubuntustudio_badge.png usr/share/unity-greeter
122-custom_usr_badge.png usr/share/unity-greeter
123-# custom_wmaker-common_badge.png provided by wmaker-common
124-custom_wmii_badge.png usr/share/unity-greeter
125-custom_XBMC_badge.png usr/share/unity-greeter
126-custom_xmonad_badge.png usr/share/unity-greeter
127-# custom_xubuntu_badge.png provided by xubuntu-artwork
128-custom_xubuntu_badge.png => /usr/share/unity-greeter/custom_xfce_badge.png
129-debian/custom_mwm_badge.png usr/share/unity-greeter
130+custom_*_badge.png usr/share/unity-greeter
131+debian/custom_*_badge.png usr/share/unity-greeter
132
133=== modified file 'debian/rules'
134--- debian/rules 2015-01-18 12:53:25 +0000
135+++ debian/rules 2015-02-28 14:28:23 +0000
136@@ -1,7 +1,34 @@
137 #!/usr/bin/make -f
138
139+DATADIR=$(CURDIR)/debian/unity-greeter-badges/usr/share/unity-greeter
140+
141+# Badges found in other packages
142+BADGESTOREMOVE = cairo-dock #cairo-dock-data
143+BADGESTOREMOVE += LXDE Lubuntu #lubuntu-artwork
144+BADGESTOREMOVE += wmaker-common #wmaker-common
145+BADGESTOREMOVE += xubuntu #xubuntu-artwork
146+
147+# But if we remove these, we break some symbolic links
148+BROKENLINKS = cairo-dock-fallback cairo-dock-unity #cairo-dock
149+BROKENLINKS += Lubuntu-Netbook lubuntu-nexus7 lxgames QLubuntu #LXDE
150+BROKENLINKS += xfce #xubuntu
151+
152 %:
153 dh $@
154
155+override_dh_install:
156+ dh_install
157+
158+# Remove badges provided in other packages
159+ for BADGE in $(BADGESTOREMOVE); do \
160+ rm $(DATADIR)/custom_$$BADGE\_badge.png; \
161+ done
162+
163+# Fix broken symlinks
164+ for BADGE in $(BROKENLINKS); do \
165+ rm $(DATADIR)/custom_$$BADGE\_badge.png; \
166+ cp -L $(CURDIR)/custom_$$BADGE\_badge.png $(DATADIR); \
167+ done
168+
169 get-orig-source:
170 uscan --verbose --force-download --rename

Subscribers

People subscribed via source and target branches

to all changes: