Merge lp:~pro-mathesh812004/ubuntu/oneiric/scim-tables/oneiric into lp:ubuntu/oneiric/scim-tables

[Promathesh Mandal]

Added two new Bengali scim layout named Webel and Samit Toptype 1

[Michael Terry (mterry)]

Thank you so much for the patch! Can you give some background/rationale for those that aren't familiar with Bengali? Did you create these layout files yourself or are they from upstream?

Also, since this package has a patch system, it would be better to create a new patch alongside the existing ones rather than change the source directly. (https://wiki.ubuntu.com/PackagingGuide/PatchSystems)

And since this package is in sync with Debian, it would be great to keep it in sync. Can you forward the patch to Debian? (https://wiki.ubuntu.com/Debian/ForUbuntuDevelopers#Forwarding_bug_reports)

review: Needs Fixing

[Chris Halse Rogers (raof)]

I'm marking this as “In Progress” to drop it off the sponsorship queue.

I'll reiterate the queries Michael had:
 * Where did these layout files come from? From the Author field it looks like you wrote them yourself - is that correct?
 * Have these layouts been submitted upstream, to the SCIM project, so that others may benefit from your work?

Also, the Copyright statement claims “All rights reserved”, which technically means that we can't distribute these files. I know some of the other tables contain similar copyright statements, but it would make it *much* clearer that we actually have the rights to distribute these tables if the header either did not have a copyright statement (and inherited the global GPL license) or explicitly stated that they were available under the GPL.

Once you've addressed these points, please set the status back to “Needs Review” and it will go back onto the sponsorship queue.

review: Needs Information

Unmerged revisions

14. By Promathesh Mandal on 2011-06-10

Added two new Bengali scim layout named Webel and Samit Toptype 1

=== modified file 'debian/scim-tables-additional.install'
--- debian/scim-tables-additional.install	2009-04-04 13:30:47 +0000
+++ debian/scim-tables-additional.install	2011-06-10 07:52:38 +0000
@@ -26,6 +26,10 @@
 usr/share/scim/icons/Bengali-inscript.png
 usr/share/scim/tables/Bengali-probhat.bin
 usr/share/scim/icons/Bengali-probhat.png
+usr/share/scim/tables/Bengali-Webel.bin
+usr/share/scim/icons/Bengali-Webel.png
+usr/share/scim/tables/Bengali-Samit-Toptype-1.bin
+usr/share/scim/icons/Bengali-Samit-Toptype-1.png
 
 usr/share/scim/tables/Gujarati-inscript.bin
 usr/share/scim/icons/Gujarati-inscript.png

=== added file 'icons/Bengali-Samit-Toptype-1.png'
Binary files icons/Bengali-Samit-Toptype-1.png	1970-01-01 00:00:00 +0000 and icons/Bengali-Samit-Toptype-1.png	2011-06-10 07:52:38 +0000 differ
=== added file 'icons/Bengali-Webel.png'
Binary files icons/Bengali-Webel.png	1970-01-01 00:00:00 +0000 and icons/Bengali-Webel.png	2011-06-10 07:52:38 +0000 differ
=== added file 'tables/bn/Bengali-Samit-Toptype-1.txt.in'
--- tables/bn/Bengali-Samit-Toptype-1.txt.in	1970-01-01 00:00:00 +0000
+++ tables/bn/Bengali-Samit-Toptype-1.txt.in	2011-06-10 07:52:38 +0000
@@ -0,0 +1,205 @@
+### File header must not be modified
+### This file must be encoded into UTF-8.
+### Copyright (c) 2011 Society for Natural Language Technology Research, Inc. All rights reserved.
+SCIM_Generic_Table_Phrase_Library_TEXT
+VERSION_1_0
+
+### Begin Table definition.
+BEGIN_DEFINITION
+
+### An unique id to distinguish this table among others.
+### Use uuidgen to generate this kind of id.
+UUID = 46f38539-3bc4-4ef1-b921-54fdb6421d79
+
+### A unique number indicates the version of this file.
+### For example the last modified date of this file.
+### This number must be less than 2^32.
+SERIAL_NUMBER = 20090820
+
+ICON = @SCIM_ICONDIR@/Bengali-Samit-Toptype-1.png
+
+### The default name of this table
+NAME = Samit-Toptype 1
+
+### The local names of this table 
+NAME.bn_IN = সমিত-টপটাইপ ১
+
+### Supported languages of this table
+LANGUAGES = bn
+
+### The author of this table
+AUTHOR = Promathesh Mandal <[e-mail]>
+
+### Prompt string to be displayed in the status area.
+STATUS_PROMPT = bn
+
+### If true then the first candidate phrase
+### will be selected automatically during inputing.
+AUTO_SELECT = TRUE
+
+### If true then a multi wildcard will be appended
+### at the end of inputing string automatically.
+AUTO_WILDCARD = FALSE
+
+### If true then the result string will be committed to client automatically.
+### This should be used with AUTO_SELECT = TRUE.
+AUTO_COMMIT = TRUE
+
+### If true then the inputted string will be automatically splitted during inputing.
+AUTO_SPLIT = TRUE
+
+### If true then the phrases' frequencies will be adjusted dynamically.
+DYNAMIC_ADJUST = FALSE
+
+### If true then the preedit area will be filled up by the current candidate phrase automatically.
+AUTO_FILL = TRUE
+
+### Whether to discard invalid key automatically.
+### This takes effact only when AUTO_FILL and AUTO_COMMIT is true.
+DISCARD_INVALID_KEY = TRUE
+
+### If true then the lookup table will always be shown if there is any candidate phrase.
+### Otherwise the lookup table won't be shown unless the user requires it by moving the preedit caret left.
+ALWAYS_SHOW_LOOKUP = FALSE
+
+### Enable full width punctuation property
+USE_FULL_WIDTH_PUNCT = FALSE
+
+### Use full width punctuation by default
+DEF_FULL_WIDTH_PUNCT = FALSE
+
+### Enable full width letter property
+USE_FULL_WIDTH_LETTER = FALSE
+
+### Use full width letter by default
+DEF_FULL_WIDTH_LETTER = FALSE
+
+### The maxmium length of a key.
+MAX_KEY_LENGTH = 1
+
+### Valid input chars.
+VALID_INPUT_CHARS = !"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~
+
+### Single wildcard char, can have multiple chars.
+###SINGLE_WILDCARD_CHAR = ?
+
+### Multi wildcard char.
+###MULTI_WILDCARD_CHAR = *
+
+### The key strokes to split inputted string.
+###SPLIT_KEYS = quoteright
+
+### The key strokes to commit the convert result to client.
+COMMIT_KEYS = space
+
+### The key strokes to forward the inputted string to client.
+FORWARD_KEYS = VoidSymbol
+
+### The key strokes to select candidiate phrases.
+SELECT_KEYS = VoidSymbol
+
+### The key strokes to page up the lookup table.
+PAGE_UP_KEYS = VoidSymbol
+
+### The key strokes to page down the lookup table.
+PAGE_DOWN_KEYS = VoidSymbol
+
+END_DEFINITION
+
+### Begin Table data.
+BEGIN_TABLE
+!	ঃ	91
+"	ঠ	21
+#	ক্ষ	87
+$	ত্র	85
+%	জ্ঞ	83
+&	ৰ	79
+'	ট	22
+(	(	75
+)	)	73
+*	ঙ	77
++	ঋ	69
+,	,	6
+-	-	72
+.	.	4
+/	য়	2
+0	০	74
+1	১	92
+2	২	90
+3	৩	88
+4	৪	86
+5	৫	84
+6	৬	82
+7	৭	80
+8	৮	78
+9	৯	76
+:	ছ	23
+;	চ	24
+<	ষ	5
+=	ৃ	70
+>	।	3
+?	য	1
+@	শ্র	89
+A	ও	41
+B	ঁ	11
+C	ণ	15
+D	্‌	37
+E	অ	63
+F	ই	35
+G	উ	33
+H	ফ	31
+I	ঘ	53
+J	ব	29
+K	খ	27
+L	থ	25
+M	শ	7
+N	ঊ	9
+O	ধ	51
+P	ঝ	49
+Q	ঔ	67
+R	ঈ	61
+S	এ	39
+T	ঊ	59
+U	ৎ	55
+V	ন	13
+W	ঐ	65
+X	এ	17
+Y	ভ	57
+Z	ও	19
+[	ড	48
+\	ৗ	44
+]	ড়	46
+^	ৱ	81
+_	ঞ	71
+`	ৈ	94
+a	‍্য	42
+b	ং	12
+c	ম	16
+d	্	38
+e	া	64
+f	ি	36
+g	ু	34
+h	প	32
+i	গ	54
+j	র	30
+k	ক	28
+l	ত	26
+m	স	8
+n	হ	10
+o	দ	52
+p	জ	50
+q	ৗ	68
+r	ী	62
+s	ে	40
+t	ূ	60
+u	ল	56
+v	ন	14
+w	আ	66
+x	ে	18
+y	ব	58
+z	র্	20
+{	ঢ	47
+|	ঔ	43
+}	ঢ়	45
+~	ঐ	93
+END_TABLE

=== added file 'tables/bn/Bengali-Webel.txt.in'
--- tables/bn/Bengali-Webel.txt.in	1970-01-01 00:00:00 +0000
+++ tables/bn/Bengali-Webel.txt.in	2011-06-10 07:52:38 +0000
@@ -0,0 +1,205 @@
+### File header must not be modified
+### This file must be encoded into UTF-8.
+### Copyright (c) 2011 Society for Natural Language Technology Research, Inc. All rights reserved.
+SCIM_Generic_Table_Phrase_Library_TEXT
+VERSION_1_0
+
+### Begin Table definition.
+BEGIN_DEFINITION
+
+### An unique id to distinguish this table among others.
+### Use uuidgen to generate this kind of id.
+UUID = 22162c95-7c4b-49c6-8817-c2c77affc6e3
+
+### A unique number indicates the version of this file.
+### For example the last modified date of this file.
+### This number must be less than 2^32.
+SERIAL_NUMBER = 20090820
+
+ICON = @SCIM_ICONDIR@/Bengali-Webel.png
+
+### The default name of this table
+NAME = Webel
+
+### The local names of this table 
+NAME.bn_IN = ওয়েবল
+
+### Supported languages of this table
+LANGUAGES = bn
+
+### The author of this table
+AUTHOR = Promathesh Mandal <[e-mail]>
+
+### Prompt string to be displayed in the status area.
+STATUS_PROMPT = bn
+
+### If true then the first candidate phrase
+### will be selected automatically during inputing.
+AUTO_SELECT = TRUE
+
+### If true then a multi wildcard will be appended
+### at the end of inputing string automatically.
+AUTO_WILDCARD = FALSE
+
+### If true then the result string will be committed to client automatically.
+### This should be used with AUTO_SELECT = TRUE.
+AUTO_COMMIT = TRUE
+
+### If true then the inputted string will be automatically splitted during inputing.
+AUTO_SPLIT = TRUE
+
+### If true then the phrases' frequencies will be adjusted dynamically.
+DYNAMIC_ADJUST = FALSE
+
+### If true then the preedit area will be filled up by the current candidate phrase automatically.
+AUTO_FILL = TRUE
+
+### Whether to discard invalid key automatically.
+### This takes effact only when AUTO_FILL and AUTO_COMMIT is true.
+DISCARD_INVALID_KEY = TRUE
+
+### If true then the lookup table will always be shown if there is any candidate phrase.
+### Otherwise the lookup table won't be shown unless the user requires it by moving the preedit caret left.
+ALWAYS_SHOW_LOOKUP = FALSE
+
+### Enable full width punctuation property
+USE_FULL_WIDTH_PUNCT = FALSE
+
+### Use full width punctuation by default
+DEF_FULL_WIDTH_PUNCT = FALSE
+
+### Enable full width letter property
+USE_FULL_WIDTH_LETTER = FALSE
+
+### Use full width letter by default
+DEF_FULL_WIDTH_LETTER = FALSE
+
+### The maxmium length of a key.
+MAX_KEY_LENGTH = 1
+
+### Valid input chars.
+VALID_INPUT_CHARS = !"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_`abcdefghijklmnopqrstuvwxyz{|}~
+
+### Single wildcard char, can have multiple chars.
+###SINGLE_WILDCARD_CHAR = ?
+
+### Multi wildcard char.
+###MULTI_WILDCARD_CHAR = *
+
+### The key strokes to split inputted string.
+###SPLIT_KEYS = quoteright
+
+### The key strokes to commit the convert result to client.
+COMMIT_KEYS = space
+
+### The key strokes to forward the inputted string to client.
+FORWARD_KEYS = VoidSymbol
+
+### The key strokes to select candidiate phrases.
+SELECT_KEYS = VoidSymbol
+
+### The key strokes to page up the lookup table.
+PAGE_UP_KEYS = VoidSymbol
+
+### The key strokes to page down the lookup table.
+PAGE_DOWN_KEYS = VoidSymbol
+
+END_DEFINITION
+
+### Begin Table data.
+BEGIN_TABLE
+!	!	91
+"	॥	21
+#	’	87
+$	৺	85
+%	%	83
+&	?	79
+'	/	22
+(	(	75
+)	)	73
+*	*	77
++	+	69
+,	,	6
+-	-	72
+.	।	4
+/	ং	2
+0	০	74
+1	১	92
+2	২	90
+3	৩	88
+4	৪	86
+5	৫	84
+6	৬	82
+7	৭	80
+8	৮	78
+9	৯	76
+:	ষ	23
+;	স	24
+<	;	5
+=	=	70
+>	.	3
+?	:	1
+@	‘	89
+A	ঙ	41
+B	উ	11
+C	ঝ	15
+D	্‌	37
+E	ণ	63
+F	থ	35
+G	ই	33
+H	ঈ	31
+I	ঢ়	53
+J	র্	29
+K	অ	27
+L	এ	25
+M	ঃ	7
+N	ঊ	9
+O	ও	51
+P	শ	49
+Q	ঠ	67
+R	ধ	61
+S	খ	39
+T	ঢ	59
+U	‍্য	55
+V	ছ	13
+W	ফ	65
+X	ঘ	17
+Y	ৎ	57
+Z	ভ	19
+[	ৃ	48
+\	ৌ	44
+]	ৈ	46
+^	/	81
+_	আ	71
+`	ঞ	94
+a	ম	42
+b	ু	12
+c	জ	16
+d	্	38
+e	ন	64
+f	ত	36
+g	ি	34
+h	ী	32
+i	ড়	54
+j	র	30
+k	া	28
+l	ে	26
+m	হ	8
+n	ূ	10
+o	ো	52
+p	ল	50
+q	ট	68
+r	দ	62
+s	ক	40
+t	ড	60
+u	য	56
+v	চ	14
+w	প	66
+x	গ	18
+y	য়	58
+z	ব	20
+{	ঋ	47
+|	ঔ	43
+}	ঐ	45
+~	ঁ	93
+END_TABLE

=== modified file 'tables/bn/Makefile.am'
--- tables/bn/Makefile.am	2005-12-11 19:55:55 +0000
+++ tables/bn/Makefile.am	2011-06-10 07:52:38 +0000
@@ -17,11 +17,11 @@
 
 SCIM_MAKE_TABLE	= $(top_builddir)/src/scim-make-table
 
-scim_tables_source   = Bengali-probhat.txt.in Bengali-inscript.txt.in
-scim_tables	     = Bengali-probhat.txt Bengali-inscript.txt
+scim_tables_source   = Bengali-probhat.txt.in Bengali-inscript.txt.in Bengali-Webel.txt.in Bengali-Samit-Toptype-1.txt.in
+scim_tables	     = Bengali-probhat.txt Bengali-inscript.txt Bengali-Webel.txt Bengali-Samit-Toptype-1.txt
 
 scim_tables_bindir = $(SCIM_TABLEDIR)
-scim_tables_bin_DATA = Bengali-probhat.bin Bengali-inscript.bin
+scim_tables_bin_DATA = Bengali-probhat.bin Bengali-inscript.bin Bengali-Webel.bin Bengali-Samit-Toptype-1.bin
 
 
 EXTRA_DIST = $(scim_tables_source)

=== modified file 'tables/bn/Makefile.in'
--- tables/bn/Makefile.in	2009-04-04 13:30:47 +0000
+++ tables/bn/Makefile.in	2011-06-10 07:52:38 +0000
@@ -34,7 +34,10 @@
 host_triplet = @host@
 subdir = tables/bn
 DIST_COMMON = $(srcdir)/Bengali-inscript.txt.in \
-	$(srcdir)/Bengali-probhat.txt.in $(srcdir)/Makefile.am \
+	$(srcdir)/Bengali-probhat.txt.in \
+	$(srcdir)/Bengali-Webel.txt.in \
+	$(srcdir)/Bengali-Samit-Toptype-1.txt.in \
+	$(srcdir)/Makefile.am \
 	$(srcdir)/Makefile.in
 ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
 am__aclocal_m4_deps = $(top_srcdir)/m4/codeset.m4 \
@@ -56,7 +59,7 @@
 	$(ACLOCAL_M4)
 mkinstalldirs = $(SHELL) $(top_srcdir)/mkinstalldirs
 CONFIG_HEADER = $(top_builddir)/config.h
-CONFIG_CLEAN_FILES = Bengali-inscript.txt Bengali-probhat.txt
+CONFIG_CLEAN_FILES = Bengali-inscript.txt Bengali-probhat.txt Bengali-Webel.txt Bengali-Samit-Toptype-1.txt
 SOURCES =
 DIST_SOURCES =
 am__vpath_adj_setup = srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`;
@@ -231,10 +234,10 @@
 top_builddir = @top_builddir@
 top_srcdir = @top_srcdir@
 SCIM_MAKE_TABLE = $(top_builddir)/src/scim-make-table
-scim_tables_source = Bengali-probhat.txt.in Bengali-inscript.txt.in
-scim_tables = Bengali-probhat.txt Bengali-inscript.txt
+scim_tables_source = Bengali-probhat.txt.in Bengali-inscript.txt.in Bengali-Webel.txt.in Bengali-Samit-Toptype-1.txt.in
+scim_tables = Bengali-probhat.txt Bengali-inscript.txt Bengali-Webel.txt Bengali-Samit-Toptype-1.txt
 scim_tables_bindir = $(SCIM_TABLEDIR)
-scim_tables_bin_DATA = Bengali-probhat.bin Bengali-inscript.bin
+scim_tables_bin_DATA = Bengali-probhat.bin Bengali-inscript.bin Bengali-Webel.bin Bengali-Samit-Toptype-1.bin
 EXTRA_DIST = $(scim_tables_source)
 CLEANFILES = $(scim_tables_bin_DATA) *.bak
 DISTCLEANFILES = $(scim_tables)
@@ -275,6 +278,10 @@
 	cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@
 Bengali-probhat.txt: $(top_builddir)/config.status $(srcdir)/Bengali-probhat.txt.in
 	cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@
+Bengali-Webel.txt: $(top_builddir)/config.status $(srcdir)/Bengali-Webel.txt.in
+	cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@
+Bengali-Samit-Toptype-1.txt: $(top_builddir)/config.status $(srcdir)/Bengali-Samit-Toptype-1.txt.in
+	cd $(top_builddir) && $(SHELL) ./config.status $(subdir)/$@
 
 mostlyclean-libtool:
 	-rm -f *.lo