Merge lp:~pqp/noise/fix-1004478 into lp:~elementary-apps/noise/trunk

[Patrick Pace]

Changed the sort_column_id of the blank column to allow for interactivity (particularly right-clicking for the column chooser menu). Left-clicking the blank column is ignored in order to prevent the user from sorting based on a potentially faulty sort_column_id.

In the event that someone does hide all of the other columns, the user will be able to simply right-click the blank column and re-enable any column once again.

[Victor Martinez (victored)]

Thanks for the fix Patrick.

I think that we shouldn't let the users disable the "Title" column either, since it doesn't make sense to do so in most -if not all- cases.

review: Approve

[Patrick Pace (pqp)]

That's certainly a good idea as well-- I figured that this would at least be a good first step, since I didn't want to disable anything without input from you or the other various Noise developers.

=== modified file 'src/Views/ListView/Lists/GenericList.vala'
--- src/Views/ListView/Lists/GenericList.vala	2012-07-26 17:29:26 +0000
+++ src/Views/ListView/Lists/GenericList.vala	2012-08-12 02:37:19 +0000
@@ -245,18 +245,22 @@
 				// Icon column
 				
 				insert_column(tvc, index);
+				var blank_column = get_column(index);
 
 				tvc.fixed_width = 24;
-				tvc.clickable = false;
-				tvc.sort_column_id = -1;
+				tvc.clickable = true;
+				tvc.sort_column_id = index; 
 				tvc.resizable = false;
 				tvc.reorderable = false;
+				tvc.set_sort_indicator (false);
 
 				tvc.clear_attributes (tvc.get_cells().nth_data(0));
 				tvc.clear_attributes (tvc.get_cells().nth_data(1));
 
 				tvc.set_cell_data_func(tvc.get_cells().nth_data(0), cellHelper.iconDataFunc);
 				tvc.set_cell_data_func(tvc.get_cells().nth_data(1), cellHelper.iconDataFunc);
+
+				blank_column.get_button().button_press_event.connect(view_header_click_blank);
 			}
 			else if(tvc.title == TreeViewSetup.COLUMN_ID) {
 				insert_column(tvc, index);
@@ -310,6 +314,18 @@
 
 		return false;
 	}
+
+   protected bool view_header_click_blank(Gtk.Widget w, Gdk.EventButton e) {
+		if(e.button == 3) {
+			column_chooser_menu.popup (null, null, null, 3, get_current_event_time());
+			return true;
+		}
+		else if(e.button == 1) {
+			return true; // Ignore left click on blank column
+		}
+
+		return false;
+	}
 	
 	void row_activated_signal(TreePath path, TreeViewColumn column) {
 		if(tvs.get_hint() == ViewWrapper.Hint.DEVICE_AUDIO || tvs.get_hint() == ViewWrapper.Hint.DEVICE_PODCAST) {