Code review comment for lp:~pponnuvel/charm-haproxy/charm-haproxy

Revision history for this message
Ponnuvel Palaniyappan (pponnuvel) wrote :

Looking at `update_nrpe_config`, I think the whole thing can be simplified with a check there..
`
def update_nrpe_config():
    config_data = config_get()
    if config_data['enable_monitoring'] is False:
        return
     ...
`
Testing this shows it works as well. Does this sound ok?

« Back to merge proposal