Merge lp:~powersj/ubuntu-test-cases/server into lp:ubuntu-test-cases/server

[Joshua Powers]

All LXC tests are currently failing across all three releases and both architectures. There are two issues that are test specific, not LXC or ISO related:

1) The LXC tests try to spin up images of various Ubuntu releases. The releases that are used are hard coded for specific versions that are now archived and no longer available. To fix this I have changed to the code to use distro_info python module to find all the supported Ubuntu releases.

2) The LXC API test appears to require sudo privileges. When running as a normal users it fails at creating the container, therefore I have added sudo to the command.

These changes should at least get the test going again, if not allow them to pass.

[Max Brustkern (nuclearbob)]

The distro_info changes look excellent. By default, all tests are run as root anyway, so I'm interested in why we need sudo in addition to that. Did you run this using the utah client (utah), the full utah process (run_utah_tests.py), or some other method?

review: Needs Information

[Joshua Powers (powersj)]

Now that I look at the failing test logs further it does look like the effective user id is root. I am trying to come up with a way to triage this further.

My original process was that I downloaded the API test and ran on local Xenial VM. When I ran as a normal user I got the following output:

Creating rootfs using 'download', arch=amd64
Traceback (most recent call last):
  File "src/python-lxc/examples/api_test.py", line 71, in <module>
    assert(container.defined)
AssertionError

Which is the same error showing up in the test output. This occurs when trying to create a container and then verify it:

print("Creating rootfs using 'download', arch=%s" % arch)
container.create("download", 0,
                 {"dist": "ubuntu",
                  "release": "trusty",
                  "arch": arch})

assert(container.defined)

However on my local machine when I run as root I do not have any errors and the API test completes successfully.

[Max Brustkern (nuclearbob)]

Yeah, utah will run as root unless the user line in the config is set to something else, so you can probably drop the sudo, and then I think this should be good to go.

[lp:~powersj/ubuntu-test-cases/server]

106. By Joshua Powers on 2016-08-23

Merging kernel size update

107. By Joshua Powers on 2016-08-23

Updating lxc tests to use distro-info over hardcoded values.

108. By Joshua Powers on 2016-08-23

Updating preseeds with new syntax.

=== modified file 'testsuites/lxc/test_lxc_simple/lxctest.py'
--- testsuites/lxc/test_lxc_simple/lxctest.py	2013-03-05 14:17:23 +0000
+++ testsuites/lxc/test_lxc_simple/lxctest.py	2016-08-01 21:09:40 +0000
@@ -1,5 +1,6 @@
 #!/usr/bin/python
 
+import distro_info
 import os
 import platform
 import subprocess
@@ -13,7 +14,7 @@
 
 
 class Lxc:
-    def __init__(self, template="ubuntu", relnum="12.04", release=None,
+    def __init__(self, template="ubuntu", release=None,
                  config=None, name=None):
         self.name = name
         if not name:
@@ -166,22 +167,15 @@
         elif self.arch == "armv7l":
             self.arch = "armel"
 
-        if self.arch == "armel" or self.arch == "armhf":
-            self.tests = [["ubuntu", 12.04, "precise"],
-                          ["ubuntu", 13.04, "raring"]]
-        else:
-            self.tests = [["ubuntu", 8.04, "lucid"],
-                          ["ubuntu", 12.04, "precise"],
-                          ["ubuntu", 13.04, "raring"],
-                          #["ubuntu-cloud", 8.04, "lucid"],
-                          #["ubuntu-cloud", 12.04, "precise"],
-                          ]
+        ubuntuinfo = distro_info.UbuntuDistroInfo()
+        ubuntusupported = ubuntuinfo.supported()
+        self.tests = [['ubuntu', u] for u in ubuntusupported]
 
     def runTest(self):
-        for (t, relnum, r) in self.tests:
+        for (t, r) in self.tests:
             try:
                 test = "initialization"
-                l = Lxc(template=t, relnum=relnum, release=r)
+                l = Lxc(template=t, release=r)
                 test = "destroy preexisting"
                 l.Destroy(ignorefail=True)
                 test = "create"