Merge lp:~powersj/ubuntu-cdimage/server-zesty-ppc64el into lp:ubuntu-cdimage

Proposed by Joshua Powers on 2017-03-28
Status: Superseded
Proposed branch: lp:~powersj/ubuntu-cdimage/server-zesty-ppc64el
Merge into: lp:ubuntu-cdimage
Diff against target: 34 lines (+10/-3)
2 files modified
lib/cdimage/tests/test_tree.py (+3/-0)
lib/cdimage/tree.py (+7/-3)
To merge this branch: bzr merge lp:~powersj/ubuntu-cdimage/server-zesty-ppc64el
Reviewer Review Type Date Requested Status
Colin Watson 2017-03-28 Needs Fixing on 2017-03-28
Review via email: mp+321187@code.launchpad.net

This proposal has been superseded by a proposal from 2017-04-07.

Commit Message

Update ubuntu-server ISO size limit for zesty ppc64el

The ubuntu-server iso for zesty ppc64el grew too large for a standard
sized ISO due to the addition of netboot. This ups the limit again on
that specific ISO. This makes no change to the existing xenial change.

To post a comment you must log in.
Colin Watson (cjwatson) :
review: Needs Fixing
Colin Watson (cjwatson) :
1647. By Joshua Powers on 2017-03-28

Add tests for ubuntu-server, fix logic

This adds tests for the various ubuntu-server ISO size changes. Also
makes sure that future versions of ppc64el can be larger given the
recent changes, not only zesty.

Joshua Powers (powersj) wrote :

Thanks for the review and comments Colin

Added some tests and fixed not falling through as well as ppc64el + zesty and future release changes.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/cdimage/tests/test_tree.py'
2--- lib/cdimage/tests/test_tree.py 2017-01-18 15:02:04 +0000
3+++ lib/cdimage/tests/test_tree.py 2017-03-28 16:39:38 +0000
4@@ -739,6 +739,9 @@
5 ("ubuntu-budgie", "zesty", "daily-live", "i386", 2000000000),
6 ("ubuntu-mate", "trusty", "daily-live", "amd64", 1073741824),
7 ("ubuntu-mate", "xenial", "daily-live", "amd64", 2000000000),
8+ ("ubuntu-server", "xenial", "daily", "amd64", 1073741824),
9+ ("ubuntu-server", "zesty", "daily", "amd64", 736665600),
10+ ("ubuntu-server", "zesty", "daily", "ppc64el", 1073741824),
11 ):
12 if dist is not None:
13 self.config["DIST"] = dist
14
15=== modified file 'lib/cdimage/tree.py'
16--- lib/cdimage/tree.py 2017-02-28 17:19:05 +0000
17+++ lib/cdimage/tree.py 2017-03-28 16:39:38 +0000
18@@ -1773,9 +1773,13 @@
19 # provisional;
20 # https://irclogs.ubuntu.com/2016/10/01/%23ubuntu-release.html#t19:06
21 return 1024 * 1024 * 1024
22- elif self.project == "ubuntu-server" and \
23- self.config["DIST"] == "xenial":
24- return 1024 * 1024 * 1024
25+ elif self.project == "ubuntu-server":
26+ if self.config["DIST"] == "xenial":
27+ return 1024 * 1024 * 1024
28+ elif self.config["DIST"] >= "zesty" and arch == "ppc64el":
29+ return 1024 * 1024 * 1024
30+ else:
31+ return 736665600
32 else:
33 if self.publish_type == "dvd":
34 # http://en.wikipedia.org/wiki/DVD_plus_RW

Subscribers

People subscribed via source and target branches