Merge lp:~powersj/ubuntu-cdimage/megabytes into lp:ubuntu-cdimage

[Joshua Powers]

Each day the daily health checks run and produce a report for over sized ISOs such as the following:

ubuntu-server/daily: xenial-server-powerpc.iso oversized by 8441856 bytes (745107456)
ubuntu-server/daily: yakkety-server-amd64.iso oversized by 117923840 bytes (854589440)
ubuntu-server/daily: yakkety-server-arm64.iso oversized by 42149888 bytes (778815488)
ubuntu-server/daily: yakkety-server-i386.iso oversized by 102195200 bytes (838860800)
ubuntu-server/daily: yakkety-server-powerpc.iso oversized by 136861696 bytes (873527296)
ubuntu-server/daily: yakkety-server-ppc64el.iso oversized by 76937216 bytes (813602816)

Producing the output in bytes is not exactly the most human readable or understandable. This merge request proposes changing the output from bytes to megabytes. The new output should read:

ubuntu-server/daily: xenial-server-powerpc.iso oversized by 8 megabytes (711)
ubuntu-server/daily: yakkety-server-amd64.iso oversized by 112 megabytes (815)
ubuntu-server/daily: yakkety-server-arm64.iso oversized by 40 megabytes (743)
ubuntu-server/daily: yakkety-server-i386.iso oversized by 97 megabytes (800)
ubuntu-server/daily: yakkety-server-powerpc.iso oversized by 131 megabytes (833)
ubuntu-server/daily: yakkety-server-ppc64el.iso oversized by 73 megabytes (776)

[Steve Langasek (vorlon)]

Brian merged this, but I have reverted it with the following rationale:

  Revert change to daily checks

  - this loses information in the output by rounding
  - in some cases the report would actually report that the image is oversized
    by "0 megabytes"
  - this is an incorrect use of megabyte for binary multiples; it either
    needs to use mibi for the current number, or switch to using decimal
    mega per https://wiki.ubuntu.com/UnitsPolicy

It is my preference that we keep this in bytes, I don't see readability of the numbers as a concern vs precision here.

review: Disapprove

=== modified file 'bin/daily-checks'
--- bin/daily-checks	2016-07-26 17:41:15 +0000
+++ bin/daily-checks	2016-09-29 23:07:35 +0000
@@ -125,8 +125,9 @@
         arch = base.split("-")[-1]
         sizelimit = publisher.size_limit(arch)
         if size > sizelimit:
-            warn(project, image, "%s oversized by %d bytes (%d)" %
-                                 (iso, size - sizelimit, size))
+            warn(project, image, "%s oversized by %d megabytes (%d)" %
+                                 (iso, bytes_to_megabytes(size - sizelimit),
+                                  bytes_to_megabytes(size)))
 
     if project == 'xubuntu':
         for manifest in filter(
@@ -184,6 +185,10 @@
     return '\n\n\n'.join(texts)
 
 
+def bytes_to_megabytes(size):
+    return round(size / 1048576.0)
+
+
 def send_warnings(config, options, projects):
     from cdimage.mail import get_notify_addresses, send_mail