Merge lp:~powersj/jenkins-launchpad-plugin/support-lp-trigger-for-git-mps into lp:jenkins-launchpad-plugin
Status: | Merged |
---|---|
Approved by: | Francis Ginther |
Approved revision: | 135 |
Merged at revision: | 132 |
Proposed branch: | lp:~powersj/jenkins-launchpad-plugin/support-lp-trigger-for-git-mps |
Merge into: | lp:jenkins-launchpad-plugin |
Diff against target: |
516 lines (+276/-31) 5 files modified
jlp/commands/launchpadTrigger.py (+10/-7) jlp/jenkinsutils.py (+12/-4) jlp/launchpadutils.py (+77/-15) tests/test_launchpadTrigger.py (+36/-2) tests/test_launchpadutils.py (+141/-3) |
To merge this branch: | bzr merge lp:~powersj/jenkins-launchpad-plugin/support-lp-trigger-for-git-mps |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis Ginther | Approve | ||
Joshua Powers (community) | Needs Resubmitting | ||
Review via email: mp+318151@code.launchpad.net |
Description of the change
Merge master and ~albaguirre's proposal for triggering git reviews, as well as voting on them, and modified to not require a repo_type be passed in, but optionally added
Ran included tests:
Ran 298 tests in 0.638s
OK
Command tested with:
./launchpadTrig
DEBUG: Going to acquire launchpad lock "launchpad-
DEBUG: Lock acquired for launchpadTrigger
DEBUG: Using "/home/
DEBUG: Provided branch name: lp:cloud-init
DEBUG: Using repo_type: auto
DEBUG: git repo: https:/
DEBUG: Users "raharper" not allowed to trigger jobs
DEBUG: Users "slystopad" not allowed to trigger jobs
./launchpadTrig
DEBUG: Going to acquire launchpad lock "launchpad-
DEBUG: Lock acquired for launchpadTrigger
DEBUG: Using "/home/
DEBUG: Provided branch name: lp:curtin
DEBUG: Using repo_type: auto
DEBUG: bazaar repo: https:/
DEBUG: Users "raharper" not allowed to trigger jobs
DEBUG: Users "pwlars" not allowed to trigger jobs
Voting tested with:
./voteOnMergePr
DEBUG: fetching repo: ~powersj/
DEBUG: mp_link: https:/
DEBUG: mp.web_link: https:/
DEBUG: Unable to get job name from build_url.Skipping check for empty commit message
DEBUG: PASSED: Continuous integration, rev:8d9f243dc67
./voteOnMergePr
DEBUG: fetching repo: ~powersj/
DEBUG: mp_link: https:/
DEBUG: mp.web_link: https:/
DEBUG: Unable to get job name from build_url.Skipping check for empty commit message
DEBUG: FAILED: Continuous integration, rev:8d9f243dc67
The result of the voting can be seen on this cloud-init git MP:
https:/
Looks really good. Just one default parameter value I'd like to see changed.
Thanks again for working on these changes.