Merge lp:~powersj/jenkins-launchpad-plugin/skip-message-check into lp:jenkins-launchpad-plugin

[Joshua Powers]

The git-ubuntu project does not care about git-commit messages and whether or not it is in the description. For voting, they would prefer to see the actual CI results and not fake failures when nothing is in the description or git-commit bucket.

This makes that check optional.

[lp:~powersj/jenkins-launchpad-plugin/skip-message-check]

139. By Joshua Powers on 2018-03-08

Moving check onto its own line

=== modified file 'jlp/commands/voteOnMergeProposal.py'
--- jlp/commands/voteOnMergeProposal.py	2015-09-24 16:09:07 +0000
+++ jlp/commands/voteOnMergeProposal.py	2018-03-08 10:03:36 +0000
@@ -17,6 +17,8 @@
                         help="Not used but kept for backwards compatibility.")
     parser.add_argument('-p', '--merge-proposal', required=True,
                         help="URL of the merge proposal to update")
+    parser.add_argument('-i', '--skip-message', action='store_true',
+                        help="Skip checking if a commit message is set")
     args = vars(parser.parse_args())
 
     # launchpadlib is not thread/process safe so we are creating launchpadlib
@@ -44,7 +46,9 @@
 
     #override the status to FAILED and set reason if no commit message is set
     match = re.match('^(.*)/job/([^/]*)/.*$', args['build_url'])
-    if match:
+    if args['skip_message']:
+        logger.debug('Skipping check for empty commit message')
+    elif match:
         jenkins_url = match.group(1)
         jenkins_job = match.group(2)
         if not launchpadutils.is_commit_message_set(mp,