Merge lp:~powersj/jenkins-launchpad-plugin/skip-message-check into lp:jenkins-launchpad-plugin

Proposed by Joshua Powers on 2018-03-07
Status: Merged
Approved by: Joshua Powers on 2018-06-25
Approved revision: 139
Merged at revision: 139
Proposed branch: lp:~powersj/jenkins-launchpad-plugin/skip-message-check
Merge into: lp:jenkins-launchpad-plugin
Diff against target: 23 lines (+5/-1)
1 file modified
jlp/commands/voteOnMergeProposal.py (+5/-1)
To merge this branch: bzr merge lp:~powersj/jenkins-launchpad-plugin/skip-message-check
Reviewer Review Type Date Requested Status
Jenkaas Hackers 2018-03-07 Pending
Review via email: mp+341020@code.launchpad.net

Description of the change

The git-ubuntu project does not care about git-commit messages and whether or not it is in the description. For voting, they would prefer to see the actual CI results and not fake failures when nothing is in the description or git-commit bucket.

This makes that check optional.

To post a comment you must log in.
139. By Joshua Powers on 2018-03-08

Moving check onto its own line

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jlp/commands/voteOnMergeProposal.py'
2--- jlp/commands/voteOnMergeProposal.py 2015-09-24 16:09:07 +0000
3+++ jlp/commands/voteOnMergeProposal.py 2018-03-08 10:03:36 +0000
4@@ -17,6 +17,8 @@
5 help="Not used but kept for backwards compatibility.")
6 parser.add_argument('-p', '--merge-proposal', required=True,
7 help="URL of the merge proposal to update")
8+ parser.add_argument('-i', '--skip-message', action='store_true',
9+ help="Skip checking if a commit message is set")
10 args = vars(parser.parse_args())
11
12 # launchpadlib is not thread/process safe so we are creating launchpadlib
13@@ -44,7 +46,9 @@
14
15 #override the status to FAILED and set reason if no commit message is set
16 match = re.match('^(.*)/job/([^/]*)/.*$', args['build_url'])
17- if match:
18+ if args['skip_message']:
19+ logger.debug('Skipping check for empty commit message')
20+ elif match:
21 jenkins_url = match.group(1)
22 jenkins_job = match.group(2)
23 if not launchpadutils.is_commit_message_set(mp,

Subscribers

People subscribed via source and target branches

to all changes: