jenkins-launchpad-plugin

Merge lp:~powersj/jenkins-launchpad-plugin/add-jenkins-pipeline-support into lp:jenkins-launchpad-plugin

  1. add-jenkins-pipeline-support
  2. Merge into trunk
Proposed by Joshua Powers
Status: Merged
Merged at revision: 134
Proposed branch: lp:~powersj/jenkins-launchpad-plugin/add-jenkins-pipeline-support
Merge into: lp:jenkins-launchpad-plugin
Diff against target: 17 lines (+7/-2)
1 file modified
jlp/jenkinsutils.py (+7/-2)
To merge this branch: bzr merge lp:~powersj/jenkins-launchpad-plugin/add-jenkins-pipeline-support
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+326245@code.launchpad.net

Commit message

Enable support for Jenkins pipeline type jobs

Pipeline jobs do not have downstream projects and currently, this
code causes a KeyError. By capturing this, it allows pipeline jobs to
get executed by the plugin.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jlp/jenkinsutils.py'
2--- jlp/jenkinsutils.py 2016-08-13 01:08:59 +0000
3+++ jlp/jenkinsutils.py 2017-06-23 19:44:12 +0000
4@@ -571,8 +571,13 @@
5 def get_downstream_projects(jenkins, job_url):
6 data = jenkins.get_json_data(job_url + '/')
7 downstream_projects = []
8- for project in data['downstreamProjects']:
9- downstream_projects.append(project['name'])
10+
11+ try:
12+ for project in data['downstreamProjects']:
13+ downstream_projects.append(project['name'])
14+ except KeyError:
15+ logger.debug('No downstream projects.')
16+
17 return downstream_projects
18
19

Subscribers

People subscribed via source and target branches

to all changes: