Merge lp:~powersj/curtin/fix-vmtest-log-exception into lp:~curtin-dev/curtin/trunk

[Joshua Powers]

vmtest: catch exceptions in curtin-log-print

Wraps the calling of curtin-log-print to catch any exceptions
that result. Was causing large image files to be left behind as
an exception generated by the curtin-log-print prevented proper
cleanup.

LP: #1714592

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:521
https://jenkins.ubuntu.com/server/job/curtin-ci/610/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/610
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/610
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/610
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/610

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/610/rebuild

review: Approve (continuous-integration)

[Ryan Harper (raharper)]

Looks good! Thanks

review: Approve

=== modified file 'tests/vmtests/__init__.py'
--- tests/vmtests/__init__.py	2017-08-15 14:59:11 +0000
+++ tests/vmtests/__init__.py	2017-09-01 21:23:08 +0000
@@ -877,8 +877,11 @@
             raise
 
         # capture curtin install log and webhook timings
-        util.subp(["tools/curtin-log-print", "--dumpfiles", cls.td.logs,
-                   cls.reporting_log], capture=True)
+        try:
+            util.subp(["tools/curtin-log-print", "--dumpfiles", cls.td.logs,
+                      cls.reporting_log], capture=True)
+        except util.ProcessExecutionError as error:
+            logger.debug('tools/curtin-log-print failed: %s', error)
 
         logger.info(
             "%s: setUpClass finished. took %.02f seconds. Running testcases.",