Merge ~powersj/cloud-init:disable-fastestmirror into cloud-init:master

[Joshua Powers]

tools: disable fastestmirror if using proxy

Per centos documentation using the fastestmirror plugin is
effective at finding the fastest mirror, unless you are behind a
proxy. In that case you should disable it. Therefore, in our tests
if we are setting the proxy we should also disable the
fastestmirror plugin.

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:636448e1555c0561122288264c440b5995efdc51
https://jenkins.ubuntu.com/server/job/cloud-init-ci/413/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    FAILED: Ubuntu LTS: Integration

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/413/rebuild

review: Needs Fixing (continuous-integration)

[Chad Smith (chad.smith)]

+1 on this changeset. We can tweak the specific mirrors we use if need be in the future. Let's see you this behaves for a while since fastest mirror is giving us fairly frequent CI failures.

review: Approve

[Chad Smith (chad.smith)]

I tested clean lxc cent6 images without fastestmirror and installing all dependencies worked fine. Same w/ updating existing systems.

[Chad Smith (chad.smith)]

Also exec'd run-centos using your sed in my environment and run-centos succeeded w/out fastest mirror

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:636448e1555c0561122288264c440b5995efdc51
https://jenkins.ubuntu.com/server/job/cloud-init-ci/414/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/414/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

on the order of a small number of milliseconds faster would be
 inside "$name" sed -i "s/enabled=1/enabled=0/" "/etc/yum/pluginconf.d/fastestmirror.conf"

ie, we do not need to invoke a shell to invoke a single command.

if you dont want to spend the several minutes to test that fix for a millisecond or so, then i'm not overly upset.

thank you for fixing the issue.

758add0... by Joshua Powers on 2017-10-19

Remove invoking shell

diff --git a/tools/run-centos b/tools/run-centos
index d44d514..e87b202 100755
--- a/tools/run-centos
+++ b/tools/run-centos
@@ -153,6 +153,7 @@ start_container() {
     if [ ! -z "${http_proxy-}" ]; then
         debug 1 "configuring proxy ${http_proxy}"
         inside "$name" sh -c "echo proxy=$http_proxy >> /etc/yum.conf"
+        inside "$name" sed -i s/enabled=1/enabled=0/ /etc/yum/pluginconf.d/fastestmirror.conf
     fi
 }