Code review comment for lp:~posulliv/mysql-sandbox/make-source-issue

Revision history for this message
Giuseppe Maxia (giuseppe-maxia) wrote :

Fixed in 3.0.08. (rev 36)
I used a slightly different change to get to make the regex more robust.

    while (my $line = <$CONFIG>) {
        if ($line =~ /
                    (?:AM_INIT_AUTOMAKE
                    |
                    AC_INIT) # either of these macros
                    \D+ # followed by one or more non digit
                    (?:(?i)mysql) # followed by "mysql" in any case
                    \D+ # followed by one or more non digit
                    (\d\.\d.\d+) # capture the version
                    /x) {
            $version = $1;
            last;
        }
    }

So, I disapprove your change (because I fixed it otherwise), but I warmly thank you for noticing it!

review: Disapprove

« Back to merge proposal