Merge lp:~posulliv/drizzle/cleanup-replace-typelib into lp:~drizzle-trunk/drizzle/development
Proposed by
Padraig O'Sullivan
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~posulliv/drizzle/cleanup-replace-typelib |
Merge into: | lp:~drizzle-trunk/drizzle/development |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~posulliv/drizzle/cleanup-replace-typelib |
Related bugs: | |
Related blueprints: |
Replace TYPELIB with STL standards
(Medium)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jay Pipes (community) | Approve | ||
Review via email: mp+4737@code.launchpad.net |
To post a comment you must log in.
This patch replaces an instance of TYPELIB with std::vector. I looked for a simple, self-contained instance of TYPELIB to start with and I found one in client/ drizzleadmin. cc. I wanted to start on a small and simple instance like this one so that I can get feedback on whether I am going about this the right way or not. I'm hoping to work on replacing more instances of TYPELIB throughout the code in the next few weeks.
I'm looking to get comments on whether what I did to replace TYPELIB in this case is the best way to go about it. I wasn't sure if I should have gone with std::map or std::vector in this case. I found it easier to go with std::vector so that was my main motivation for using it here.