Merge lp:~porten-deactivatedaccount/eventum/devel into lp:eventum

Proposed by Harri Porten
Status: Merged
Merged at revision: 4272
Proposed branch: lp:~porten-deactivatedaccount/eventum/devel
Merge into: lp:eventum
Diff against target: 17 lines (+2/-2)
1 file modified
lib/eventum/class.session.php (+2/-2)
To merge this branch: bzr merge lp:~porten-deactivatedaccount/eventum/devel
Reviewer Review Type Date Requested Status
Eventum Development Team Pending
Review via email:

Description of the change

We found the following notices in our Apache log:

  PHP Notice: A session had already been started - ignoring session_start() in /var/www/eventum-2.3.0/lib/eventum/class.session.php on line 87

So we changed the logic to avoid repeated calls. We were the only one to see this? Maybe others have Notices disabled in their production system?

To post a comment you must log in.
Revision history for this message
Elan Ruusamäe (glen666) wrote :

Nah, I've seen it too my my logs, just never bothered to find and fix it :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/eventum/class.session.php'
2--- lib/eventum/class.session.php 2010-08-26 19:08:48 +0000
3+++ lib/eventum/class.session.php 2011-01-26 20:58:25 +0000
4@@ -108,12 +108,12 @@
5 */
6 function verify($usr_id)
7 {
8- session_start();
10 // Don't check the IP of the session, since this caused problems for users that use a proxy farm that uses
11 // a different IP address each page load.
12 if (!self::is_set('usr_id')) {
13 self::init($usr_id);
14+ } else {
15+ session_start();
16 }
17 }


People subscribed via source and target branches