Merge lp:~popey/ubuntu-weather-app/manual-tests into lp:ubuntu-weather-app

Status: Superseded
Proposed branch: lp:~popey/ubuntu-weather-app/manual-tests
Merge into: lp:ubuntu-weather-app
Diff against target: 252 lines (+232/-0)
4 files modified
tests/manual/weather-firstrun.pxu (+64/-0)
tests/manual/weather-forecasts.pxu (+57/-0)
tests/manual/weather-locations.pxu (+76/-0)
tests/manual/weather-settings.pxu (+35/-0)
To merge this branch: bzr merge lp:~popey/ubuntu-weather-app/manual-tests
Reviewer Review Type Date Requested Status
Victor Thompson Needs Fixing
Jenkins Bot continuous-integration Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+272733@code.launchpad.net

This proposal has been superseded by a proposal from 2015-12-16.

Commit message

Add manual tests

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

These are fine, but will need a provider and folder layout to make them plug and play. I'll bundle them and try them before providing a diff.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

These work. Some comments

Avoid using dashes for the file name
s/first-run/firstrun/

Prefix the tests file names with 'weather-'

You are missing a colon
s/_description/_description:/g

review: Needs Fixing
130. By Alan Pope 🍺🐧🐱 πŸ¦„

update based on feedback from balloons

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

See 1 inline comment.

Also:
1. Please add an entry to the changelog, we're trying to maintain this file as we make fixes/updates.
2. There seem to be a lot of indentation issues. Is that problematic at all? Will it show up in an odd fashion to those running through the tests?

review: Needs Fixing

Unmerged revisions

130. By Alan Pope 🍺🐧🐱 πŸ¦„

update based on feedback from balloons

129. By Alan Pope 🍺🐧🐱 πŸ¦„

Add manual tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'tests/manual'
2=== added file 'tests/manual/weather-firstrun.pxu'
3--- tests/manual/weather-firstrun.pxu 1970-01-01 00:00:00 +0000
4+++ tests/manual/weather-firstrun.pxu 2015-09-29 23:44:36 +0000
5@@ -0,0 +1,64 @@
6+id: firstrun/check-icon
7+plugin: manual
8+_summary: Test to check correct icon is used
9+estimated_duration: 600
10+_description:
11+ Test to check correct icon is used
12+ 1. Install weather reboot
13+ Weather icon with a cloud and 12-spiked sun should appear in the dash
14+
15+id: firstrun/location-check
16+plugin: manual
17+_summary: Test to confirm location is requested
18+estimated_duration: 600
19+_description:
20+ Test to confirm location is requested
21+ 1. Launch weather reboot
22+ Expect to see 'location acceptance screen'
23+
24+id: firstrun/location-deny
25+plugin: manual
26+_summary: Test to confirm effect of denying location access
27+estimated_duration: 600
28+_description:
29+ Test to confirm effect of denying location access
30+ 1. Launch weather reboot
31+ Expect to see 'location acceptance screen'
32+ 2. Choose 'deny'
33+ Expect to see the "Cannoy determine your location", "Manually add" screen
34+
35+id: firstrun/location-allow
36+plugin: manual
37+_summary: Test to confirm effect of allowing location access
38+estimated_duration: 600
39+_description:
40+ Test to confirm effect of allowing location access
41+ 1. Close weather app (if already open)
42+ 2. Launch System Settings
43+ 3. Choose "Security & Privacy"
44+ 4. Choose "Location Access"
45+ 5. Switch location access for weather app on
46+ This reverses the location denial from the previous test
47+ 6. Launch weather reboot
48+ Expect to _not_ see 'location acceptance screen'
49+ 7. Wait for a short while
50+ Expect to see weather for your current location
51+
52+id: firstrun/pull-refresh
53+plugin: manual
54+_summary: Test to confirm pull to refresh works
55+estimated_duration: 600
56+_description:
57+ Test to confirm pull to refresh works
58+ 1. Launch weather reboot
59+ Expect to see weather details for current location
60+ 2. Pull down the screen to refresh
61+ Expect to see 'Pull down to refresh' then 'Release to refresh'
62+ 3. Let go of the screen
63+ Expect view to refresh - although you may not see any difference if the data recently refreshed
64+
65+
66+
67+
68+
69+
70
71=== added file 'tests/manual/weather-forecasts.pxu'
72--- tests/manual/weather-forecasts.pxu 1970-01-01 00:00:00 +0000
73+++ tests/manual/weather-forecasts.pxu 2015-09-29 23:44:36 +0000
74@@ -0,0 +1,57 @@
75+id: forecasts/test-daily-forecast
76+plugin: manual
77+_summary: Test to future day forecast is shown
78+estimated_duration: 600
79+_description:
80+ Test to future day forecast is shown
81+ 1. Launch weather app
82+ Expect to see weather for your current location
83+ 2. Scroll up
84+ Expect to see weather for at least the following 4 days
85+
86+id: forecasts/test-hourly-forecast-detail
87+plugin: manual
88+_summary: Test to ensure hourly forecast detail is shown
89+estimated_duration: 600
90+_description:
91+ Test to ensure hourly forecast detail is shown
92+ 1. Launch weather app
93+ Expect to see weather for your current location
94+ 2. Tap large current weather icon (cloud/sun/rain) in the top half of the display
95+ Expect to see weather for the following hours
96+ 3. Swipe right and left
97+ Expect to see further details about the weather on coming hours
98+ 4. Tap in that area again
99+ Expect the previously shown current weather icon to be displayed
100+
101+id: forecasts/test-daily-forecast-detail
102+plugin: manual
103+_summary: Test to ensure daily forecast detail is shown
104+estimated_duration: 600
105+_description:
106+ Test to ensure daily forecast detail is shown
107+ 1. Launch weather app
108+ Expect to see weather for your current location
109+ 2. Scroll up
110+ Expect to see weather for at least the following 4 days
111+ 3. Tap any day in the future
112+ Expect to see further details about the weather on that day
113+ 4. Tap any other day
114+ Expect the previously tapped day to shrink, and the newly tapped day to expand
115+ 5. Tap the same day again
116+ Expect the tapped day detail to shrink
117+
118+id: forecasts/test-final-day
119+plugin: manual
120+_summary: Test to ensure UI expands properly
121+estimated_duration: 600
122+_description:
123+ Test to ensure UI expands properly
124+ 1. Launch weather app
125+ Expect to see weather for your current location
126+ 2. Scroll up to the very bottom
127+ Expect to see weather for at least the following 4 days
128+ 3. Tap the final day in the list
129+ Expect it to expand, and still be on screen (i.e. not expanded off-screen)
130+
131+
132
133=== added file 'tests/manual/weather-locations.pxu'
134--- tests/manual/weather-locations.pxu 1970-01-01 00:00:00 +0000
135+++ tests/manual/weather-locations.pxu 2015-09-29 23:44:36 +0000
136@@ -0,0 +1,76 @@
137+id: locations/show-list-of-locations
138+plugin: manual
139+_summary: Test to see a list of locations
140+estimated_duration: 600
141+_description:
142+ Test to see a list of locations
143+ 1. Launch weather app
144+ Expect to see weather for your current location
145+ 2. Swipe up from the bottom of the screen
146+ Expect to see a list of locations (only one location on first run, or no locations if gps access denied)
147+
148+id: locations/add-pre-defined-location
149+plugin: manual
150+_summary: Test to add a location from a pre-defined list
151+estimated_duration: 600
152+_description:
153+ Test to add a location from a pre-defined list
154+ 1. Launch weather app
155+ Expect to see weather for your current location
156+ 2. Swipe up from the bottom of the screen
157+ Expect to see a list of locations (only one location on first run, or no locations if gps access denied)
158+ 3. Press "+" icon
159+ Expect to see a pre-defined list of city names
160+ 4. Tap any city on the list
161+ Expect to see it added to the list of locations
162+ 5. Continue to add more cities
163+ There is a hard wired limit of 7 locations currently
164+
165+id: locations/switch-location-by-swipe
166+plugin: manual
167+_summary: Test to switch locations by swiping
168+estimated_duration: 600
169+_description:
170+ Test to switch locations by swiping
171+ 1. Launch weather app
172+ Expect to see weather for your current location
173+ 2. Swipe left
174+ Expect to switch location
175+ 3. Swipe right
176+ Expect to switch back to previous location
177+
178+id: locations/switch-location-by-edge
179+plugin: manual
180+_summary: Test to switch locations using bottom edge
181+estimated_duration: 600
182+_description:
183+ Test to switch locations using bottom edge
184+ 1. Launch weather app
185+ Expect to see weather for your current location
186+ 2. Swipe up from the bottom of the screen
187+ Expect to see a list of locations
188+ 3. Tap a location
189+ Expect to be returned to the main screen, showing weather for selected location
190+
191+id: locations/delete-location
192+plugin: manual
193+_summary: Test to remove locations
194+estimated_duration: 600
195+_description:
196+ Test to remove locations
197+ 1. Launch weather app
198+ Expect to see weather for your current location
199+ 2. Swipe up from the bottom of the screen
200+ Expect to see a list of locations
201+ 3. Swipe a location to the right
202+ Expect to see a delete option
203+ 4. Swipe location left again
204+ Expect location NOT to be deleted
205+ 5. Swipe a location to the right
206+ Expect to see a delete option
207+ 6. Tap delete (trash) button
208+ Expect location to be deleted
209+
210+
211+
212+
213
214=== added file 'tests/manual/weather-settings.pxu'
215--- tests/manual/weather-settings.pxu 1970-01-01 00:00:00 +0000
216+++ tests/manual/weather-settings.pxu 2015-09-29 23:44:36 +0000
217@@ -0,0 +1,35 @@
218+id: settings/change-units-temp
219+plugin: manual
220+_summary: Test to change temperature units
221+estimated_duration: 600
222+_description:
223+ Test to change temperature units
224+ 1. Launch weather app
225+ Expect to see weather for your current location
226+ 2. Tap settings cog in top right corner
227+ Expect to see a list of settings
228+ 3. Tap "Units"
229+ Expect to see 'Units' screen
230+ 4. Tap "Temperature"
231+ Expect to see options unfolded
232+ 5. Switch to different temperature units and go back to main screen
233+ Expect units shown to be different
234+
235+id: settings/change-units-speed
236+plugin: manual
237+_summary: Test to change wind speed units
238+estimated_duration: 600
239+_description:
240+ Test to change wind speed units
241+ 1. Launch weather app
242+ Expect to see weather for your current location
243+ 2. Tap settings cog in top right corner
244+ Expect to see a list of settings
245+ 3. Tap "Units"
246+ Expect to see 'Units' screen
247+ 4. Tap "Wind Speed"
248+ Expect to see options unfolded
249+ 5. Switch to different wind speed units and go back to main screen
250+ Expect wind speed units shown to be different
251+
252+

Subscribers

People subscribed via source and target branches