Merge lp:~popey/ubuntu-terminal-app/fix-1514519 into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Status: Merged
Approved by: Nicholas Skaggs on 2015-12-10
Approved revision: 140
Merged at revision: 142
Proposed branch: lp:~popey/ubuntu-terminal-app/fix-1514519
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 14 lines (+2/-2)
1 file modified
src/app/qml/TerminalSettings.qml (+2/-2)
To merge this branch: bzr merge lp:~popey/ubuntu-terminal-app/fix-1514519
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve on 2015-12-10
Michael Hall 2015-11-11 Approve on 2015-11-12
Review via email: mp+277240@code.launchpad.net

Commit message

Allow for smaller font point sizes and set a lower default (5pt) to fix/workaround LP:#1514519

To post a comment you must log in.
Michael Hall (mhall119) wrote :

LGTM

review: Approve

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

Set to Needs Review because Jenkins is having an incredibly BAD DAY.

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)

ERROR: failed to start a jenkins job

review: Disapprove (continuous-integration)
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/TerminalSettings.qml'
2--- src/app/qml/TerminalSettings.qml 2015-08-09 14:03:25 +0000
3+++ src/app/qml/TerminalSettings.qml 2015-11-12 12:33:49 +0000
4@@ -10,8 +10,8 @@
5 property alias colorScheme: innerSettings.colorScheme
6 property alias showKeyboardBar: innerSettings.showKeyboardBar
7
8- readonly property int defaultFontSize: 14
9- readonly property int minFontSize: 8
10+ readonly property int defaultFontSize: units.gu(0.4)
11+ readonly property int minFontSize: 2
12 readonly property int maxFontSize: 32
13
14 property alias jsonVisibleProfiles: innerSettings.jsonVisibleProfiles

Subscribers

People subscribed via source and target branches