Merge lp:~popey/ubuntu-terminal-app/fix-1430660 into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Status: Work in progress
Proposed branch: lp:~popey/ubuntu-terminal-app/fix-1430660
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 18 lines (+8/-0)
1 file modified
src/app/qml/KeyboardRows/Layouts/ControlKeys.json (+8/-0)
To merge this branch: bzr merge lp:~popey/ubuntu-terminal-app/fix-1430660
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Terminal Developers Pending
Review via email:

Commit message

Seems more people than we thought use nano for editing random text files, and having CTRL+X on the CTRL bar is handy for those people. Longer term we should have a nano specific layout.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Now we have a merge for a full nano profile, it seems less useful to have this.

Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Yes I agree. Personally I can't think of another good reason to have CTRL+X shortcut.

Revision history for this message
Evan McIntire (mcintire-evan) wrote :

In the interest of cleaning things up, should this be marked as "Rejected" (I don't see the option to mark it as superseded or any such thing)

Unmerged revisions

69. By Alan Pope 🍺🐧🐱 πŸ¦„

fix 1430660

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/KeyboardRows/Layouts/ControlKeys.json'
2--- src/app/qml/KeyboardRows/Layouts/ControlKeys.json 2015-02-03 21:43:38 +0000
3+++ src/app/qml/KeyboardRows/Layouts/ControlKeys.json 2015-03-25 08:56:58 +0000
4@@ -30,6 +30,14 @@
5 {
6 "main_action" : {
7 "type": "key",
8+ "text" : "CTRL+X",
9+ "key" : "X",
10+ "mod" : "Control"
11+ }
12+ },
13+ {
14+ "main_action" : {
15+ "type": "key",
16 "text" : "CTRL+Z",
17 "key" : "Z",
18 "mod" : "Control"


People subscribed via source and target branches