Ubuntu Terminal App

Merge lp:~popey/ubuntu-terminal-app/fix-1343505 into lp:ubuntu-terminal-app

  1. fix-1343505
  2. Merge into trunk
Proposed by Alan Pope 🍺🐧🐱 🦄
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 91
Merged at revision: 91
Proposed branch: lp:~popey/ubuntu-terminal-app/fix-1343505
Merge into: lp:ubuntu-terminal-app
Diff against target: 51 lines (+1/-7)
2 files modified
CMakeLists.txt (+0/-5)
manifest.json (+1/-2)
To merge this branch: bzr merge lp:~popey/ubuntu-terminal-app/fix-1343505
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+227249@code.launchpad.net

Commit message

fix 1343505 to remove urls

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:91
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/68/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1058
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1058/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/12

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/68/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-04-27 16:02:02 +0000
3+++ CMakeLists.txt 2014-07-17 19:44:50 +0000
4@@ -12,7 +12,6 @@
5
6 set(APP_NAME terminal)
7 set(DESKTOP_FILE "${PROJECT_NAME}.desktop")
8-set(URLS_FILE "${PROJECT_NAME}.url-dispatcher")
9 set(APP_HARDCODE ubuntu-terminal-app)
10 set(MAIN_QML ubuntu-terminal-app.qml)
11 set(ICON_FILE terminal64.png)
12@@ -35,7 +34,6 @@
13 set(CMAKE_INSTALL_BINDIR /)
14 set(DATA_DIR /)
15 set(DESKTOP_DIR ${DATA_DIR})
16- set(URLS_DIR ${DATA_DIR})
17 set(ICON ${ICON_FILE})
18 set(QT_IMPORTS_DIR "/lib/${ARCH_TRIPLET}")
19 set(BIN_DIR /lib/${ARCH_TRIPLET}/bin)
20@@ -53,7 +51,6 @@
21 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_NAME})
22 set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON_FILE})
23 set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
24- set(URLS_DIR ${CMAKE_INSTALL_DATADIR}/url-dispatcher/urls)
25 endif(CLICK_MODE)
26
27 file(GLOB_RECURSE I18N_SRC_FILES
28@@ -71,8 +68,6 @@
29 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
30 DESTINATION ${DESKTOP_DIR})
31
32-install(FILES ${URLS_FILE} DESTINATION ${URLS_DIR})
33-
34 # Tests
35 enable_testing()
36
37
38=== removed file 'com.ubuntu.terminal.url-dispatcher'
39=== modified file 'manifest.json'
40--- manifest.json 2014-07-02 16:55:27 +0000
41+++ manifest.json 2014-07-17 19:44:50 +0000
42@@ -5,8 +5,7 @@
43 "hooks": {
44 "terminal": {
45 "apparmor": "apparmor.json",
46- "desktop": "com.ubuntu.terminal.desktop",
47- "urls": "com.ubuntu.terminal.url-dispatcher"
48+ "desktop": "com.ubuntu.terminal.desktop"
49 }
50 },
51 "icon": "terminal64.png",

Subscribers

People subscribed via source and target branches