Merge lp:~popey/ubuntu-filemanager-app/update-colours into lp:ubuntu-filemanager-app
| Status: | Rejected |
|---|---|
| Rejected by: | Alan Pope πΊπ§π± π¦ on 2016-01-28 |
| Proposed branch: | lp:~popey/ubuntu-filemanager-app/update-colours |
| Merge into: | lp:ubuntu-filemanager-app |
| Prerequisite: | lp:~fboucault/ubuntu-filemanager-app/migrate_toolkit_13 |
| Diff against target: |
612 lines (+108/-148) 7 files modified
com.ubuntu.filemanager.desktop.in.in (+2/-0) po/com.ubuntu.filemanager.pot (+93/-136) src/app/qml/components/PathHistoryRow.qml (+5/-5) src/app/qml/components/PlacesSidebar.qml (+1/-0) src/app/qml/filemanager.qml (+3/-3) src/app/qml/upstream/FakeHeader.qml (+2/-2) src/app/qml/upstream/PageWithBottomEdge.qml (+2/-2) |
| To merge this branch: | bzr merge lp:~popey/ubuntu-filemanager-app/update-colours |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jenkins Bot | continuous-integration | Needs Fixing on 2016-01-29 | |
| Ubuntu File Manager Developers | 2016-01-19 | Pending | |
|
Review via email:
|
|||
Commit Message
Change colour theme to match other core apps
Description of the Change
Change colour theme to match other core apps
FAILED: Continuous integration, rev:522
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
| Arto Jalkanen (ajalkane) wrote : | # |
Looks fine to me, except that the commit includes changes to .pot file. If I remember correctly these should not be committed.
Then there is of course the issue of autopilot failing...
- 523. By Alan Pope πΊπ§π± π¦ on 2016-01-28
-
remove erroneous pot file change
FAILED: Continuous integration, rev:523
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
Unmerged revisions
- 523. By Alan Pope πΊπ§π± π¦ on 2016-01-28
-
remove erroneous pot file change
- 522. By Alan Pope πΊπ§π± π¦ on 2016-01-19
-
Change colour theme to match other core apps

FAILED: Continuous integration, rev:522 /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 146/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/423/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ run-ap- tests-ci/ 146/rebuild
https:/