Merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text into lp:ubuntu-filemanager-app

Status: Merged
Approved by: Carlos Jose Mazieri on 2015-10-20
Approved revision: 482
Merged at revision: 482
Proposed branch: lp:~popey/ubuntu-filemanager-app/suppress-predictive-text
Merge into: lp:ubuntu-filemanager-app
Diff against target: 37 lines (+3/-3)
3 files modified
src/app/qml/ui/GoToDialog.qml (+1/-1)
src/app/qml/ui/PlacesPage.qml (+1/-1)
src/app/qml/ui/ViewPopover.qml (+1/-1)
To merge this branch: bzr merge lp:~popey/ubuntu-filemanager-app/suppress-predictive-text
Reviewer Review Type Date Requested Status
Carlos Jose Mazieri 2015-10-20 Approve on 2015-10-20
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-10-20
Review via email: mp+274995@code.launchpad.net

Commit message

Found a few more places in the UI where the OSK uses predictive text. Disabled these.

To post a comment you must log in.
review: Approve (continuous-integration)

OK, Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/ui/GoToDialog.qml'
2--- src/app/qml/ui/GoToDialog.qml 2014-11-30 10:26:19 +0000
3+++ src/app/qml/ui/GoToDialog.qml 2015-10-20 10:05:20 +0000
4@@ -36,7 +36,7 @@
5 id: locationField
6 objectName: "inputField"
7
8- inputMethodHints: Qt.ImhNoAutoUppercase
9+ inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
10
11 property bool valid: pathExists(text)
12
13
14=== modified file 'src/app/qml/ui/PlacesPage.qml'
15--- src/app/qml/ui/PlacesPage.qml 2015-01-06 19:56:17 +0000
16+++ src/app/qml/ui/PlacesPage.qml 2015-10-20 10:05:20 +0000
17@@ -54,7 +54,7 @@
18 margins: units.gu(1)
19 }
20
21- inputMethodHints: Qt.ImhNoAutoUppercase
22+ inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
23
24 property bool valid: pathExists(text)
25
26
27=== modified file 'src/app/qml/ui/ViewPopover.qml'
28--- src/app/qml/ui/ViewPopover.qml 2014-09-20 10:49:51 +0000
29+++ src/app/qml/ui/ViewPopover.qml 2015-10-20 10:05:20 +0000
30@@ -140,7 +140,7 @@
31 margins: units.gu(1)
32 }
33
34- inputMethodHints: Qt.ImhNoAutoUppercase
35+ inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
36
37 text: pageModel.nameFilters
38

Subscribers

People subscribed via source and target branches