Ubuntu Calendar App

Merge lp:~popey/ubuntu-calendar-app/fix_weekview into lp:ubuntu-calendar-app

  1. fix_weekview
  2. Merge into trunk
Proposed by Alan Pope 🍺🐧🐱 🦄 on 2015-06-01
Status: Merged
Approved by: Kunal Parmar on 2015-06-01
Approved revision: 654
Merged at revision: 654
Proposed branch: lp:~popey/ubuntu-calendar-app/fix_weekview
Merge into: lp:ubuntu-calendar-app
Diff against target: 11 lines (+1/-1)
1 file modified
tests/autopilot/calendar_app/tests/test_weekview.py (+1/-1)
To merge this branch: bzr merge lp:~popey/ubuntu-calendar-app/fix_weekview
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2015-06-01
Kunal Parmar 2015-06-01 Approve on 2015-06-01
Review via email: mp+260689@code.launchpad.net

Commit Message

Fix test which fails on months with more than 4 weeks.

Description of the Change

This test skips forward 4 weeks in the week view then checks to make sure the month name / year number has changed. This week that won't happen because June 2015 has 5 weeks, not 4. Changed test to skip forward 6 weeks to guarantee it always changes month.

To post a comment you must log in.
Kunal Parmar (pkunal-parmar) wrote :

looks good to me

review: Approve
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/calendar_app/tests/test_weekview.py'
2--- tests/autopilot/calendar_app/tests/test_weekview.py 2015-05-22 08:51:59 +0000
3+++ tests/autopilot/calendar_app/tests/test_weekview.py 2015-06-01 09:18:46 +0000
4@@ -92,7 +92,7 @@
5 """Changing week across months should update the month"""
6 header = self.app.main_view.get_header()
7 before_month = self.app.main_view.get_month_year(header)
8- self.week_view.change_week(4)
9+ self.week_view.change_week(6)
10
11 after_month = self.app.main_view.get_month_year(header)
12

Subscribers

People subscribed via source and target branches

to status/vote changes: