Merge lp:~popey/reminders-app/fix-1434500 into lp:reminders-app

[Alan Pope 🍺🐧🐱 🦄]

Rename user facing parts from Reminders to Notes

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:387
http://91.189.93.70:8080/job/reminders-app-ci/724/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2383
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2383/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/326
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/145

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/724/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

I've been using the app a bit and watching out for issues with this: One of them is that the OAuth plugin requests the user to grant access to the "Reminders" app. Unfortunately, that string is located on the Evernote end and we can't change that ourselved.

Also I'm still really not sure if it's a good idea to just rename some parts, keeping appid to reminders. I'm worried his will cause confusion.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Further to our various discussions about this branch on IRC and hangouts, shall we land, build a click and do some wider testing?

[Michael Zanetti (mzanetti)]

review: Needs Fixing

[lp:~popey/reminders-app/fix-1434500]

388. By Alan Pope 🍺🐧🐱 🦄 on 2015-05-28

Fix erroneous rename

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:388
http://91.189.93.70:8080/job/reminders-app-ci/750/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2830
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2830/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/352
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/172

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/750/rebuild

review: Approve (continuous-integration)

[Michael Zanetti (mzanetti)]

yeehaa!

I propose following plan:

a) Build a package with the 3 critical fixes, the rename and the icon
b) Distribute it for testing to some known users
c) Contact Evernote to update the key's name from Reminders to Notes

review: Approve

=== modified file 'com.ubuntu.reminders.desktop.in.in'
--- com.ubuntu.reminders.desktop.in.in	2014-09-28 08:31:38 +0000
+++ com.ubuntu.reminders.desktop.in.in	2015-05-28 09:49:37 +0000
@@ -1,6 +1,6 @@
 [Desktop Entry]
-_Name=Reminders
-_Comment=Ubuntu Reminders app, powered by Evernote
+_Name=Notes
+_Comment=Ubuntu Notes app, powered by Evernote
 Exec=@EXEC@
 Icon=@ICON@
 Terminal=false

=== modified file 'com.ubuntu.reminders_reminders.application.in'
--- com.ubuntu.reminders_reminders.application.in	2014-09-24 15:02:10 +0000
+++ com.ubuntu.reminders_reminders.application.in	2015-05-28 09:49:37 +0000
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8" ?>
 <application id="@PROJECT_NAME@_@APP_NAME@">
 
-  <description>Reminders</description>
+  <description>Notes</description>
 
   <services>
     <service id="com.ubuntu.reminders_reminders">

=== modified file 'debian/control'
--- debian/control	2014-12-16 22:35:59 +0000
+++ debian/control	2015-05-28 09:49:37 +0000
@@ -34,7 +34,7 @@
          suru-icon-theme | ubuntu-mobile-icons,
          ${misc:Depends},
          ${shlibs:Depends}
-Description: Reminders application
+Description: Notes application
  Note taking application powered by Evernote
 
 Package: qtdeclarative5-evernote0.1
@@ -79,5 +79,5 @@
          reminders-app (>= ${source:Version}),
          ubuntu-ui-toolkit-autopilot,
          ${misc:Depends}
-Description: Test package for the Reminders app
- Autopilot tests for the Reminders app package
+Description: Test package for the Notes app
+ Autopilot tests for the Notes app package

=== modified file 'manifest.json.in'
--- manifest.json.in	2015-02-12 20:34:11 +0000
+++ manifest.json.in	2015-05-28 09:49:37 +0000
@@ -1,5 +1,5 @@
 {
-    "description": "Ubuntu Reminders app, powered by Evernote",
+    "description": "Ubuntu Notes app, powered by Evernote",
     "framework": "ubuntu-sdk-14.10",
     "architecture": "@CLICK_ARCH@",
     "hooks": {
@@ -21,7 +21,7 @@
     },
     "maintainer": "Ubuntu App Cats <[e-mail]>",
     "name": "com.ubuntu.reminders",
-    "title": "Reminders",
+    "title": "Notes",
     "version": "0.5.@BZR_REVNO@",
     "x-source": {
         "vcs-bzr": "lp:reminders-app",