Merge lp:~popey/notes-app/fix-non-starting into lp:notes-app

Status: Approved
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 302
Proposed branch: lp:~popey/notes-app/fix-non-starting
Merge into: lp:notes-app
Diff against target: 29 lines (+3/-4)
1 file modified
NotesApp.qml (+3/-4)
To merge this branch: bzr merge lp:~popey/notes-app/fix-non-starting
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+270425@code.launchpad.net

Commit message

Should fix non-starting notes-app on latest images. Updated to latest Ubuntu Components. Removed old UnityActions reference.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

302. By Alan Pope 🍺🐧🐱 πŸ¦„

Fix non-starting on latest images

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NotesApp.qml'
--- NotesApp.qml 2013-10-08 09:52:53 +0000
+++ NotesApp.qml 2015-09-08 16:16:50 +0000
@@ -15,9 +15,8 @@
15 */15 */
1616
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 0.118import Ubuntu.Components 1.1
19import Ubuntu.Components.ListItems 0.1 as ListItem19import Ubuntu.Components.ListItems 0.1 as ListItem
20import Ubuntu.Unity.Action 1.0 as UnityActions
21import NotesApp.Plugins 0.120import NotesApp.Plugins 0.1
22import "Components"21import "Components"
23import "Models"22import "Models"
@@ -30,12 +29,12 @@
30 automaticOrientation: true29 automaticOrientation: true
3130
32 actions: [31 actions: [
33 UnityActions.Action {32 Action {
34 text: i18n.tr("Add")33 text: i18n.tr("Add")
35 keywords: i18n.tr("Create New Note")34 keywords: i18n.tr("Create New Note")
36 onTriggered: notesMainWindow.createNewNote()35 onTriggered: notesMainWindow.createNewNote()
37 },36 },
38 UnityActions.Action {37 Action {
39 text: i18n.tr("Delete")38 text: i18n.tr("Delete")
40 keywords: i18n.tr("Trash;Erase Note")39 keywords: i18n.tr("Trash;Erase Note")
41 enabled: noteList.currentIndex !== -140 enabled: noteList.currentIndex !== -1

Subscribers

People subscribed via source and target branches