Merge lp:~popey/notes-app/fix-non-starting into lp:notes-app

Status: Approved
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 302
Proposed branch: lp:~popey/notes-app/fix-non-starting
Merge into: lp:notes-app
Diff against target: 29 lines (+3/-4)
1 file modified
NotesApp.qml (+3/-4)
To merge this branch: bzr merge lp:~popey/notes-app/fix-non-starting
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+270425@code.launchpad.net

Commit message

Should fix non-starting notes-app on latest images. Updated to latest Ubuntu Components. Removed old UnityActions reference.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

302. By Alan Pope 🍺🐧🐱 πŸ¦„

Fix non-starting on latest images

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NotesApp.qml'
2--- NotesApp.qml 2013-10-08 09:52:53 +0000
3+++ NotesApp.qml 2015-09-08 16:16:50 +0000
4@@ -15,9 +15,8 @@
5 */
6
7 import QtQuick 2.0
8-import Ubuntu.Components 0.1
9+import Ubuntu.Components 1.1
10 import Ubuntu.Components.ListItems 0.1 as ListItem
11-import Ubuntu.Unity.Action 1.0 as UnityActions
12 import NotesApp.Plugins 0.1
13 import "Components"
14 import "Models"
15@@ -30,12 +29,12 @@
16 automaticOrientation: true
17
18 actions: [
19- UnityActions.Action {
20+ Action {
21 text: i18n.tr("Add")
22 keywords: i18n.tr("Create New Note")
23 onTriggered: notesMainWindow.createNewNote()
24 },
25- UnityActions.Action {
26+ Action {
27 text: i18n.tr("Delete")
28 keywords: i18n.tr("Trash;Erase Note")
29 enabled: noteList.currentIndex !== -1

Subscribers

People subscribed via source and target branches