Merge lp:~popey/music-app/fix-1392587 into lp:music-app/remix

Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 739
Merged at revision: 739
Proposed branch: lp:~popey/music-app/fix-1392587
Merge into: lp:music-app/remix
Diff against target: 11 lines (+1/-0)
1 file modified
meta-database.js (+1/-0)
To merge this branch: bzr merge lp:~popey/music-app/fix-1392587
Reviewer Review Type Date Requested Status
Oliver Grawert (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Music App Developers Pending
Review via email: mp+241770@code.launchpad.net

Commit message

Fix 1392587

Description of the change

In testing we found the queue doesn't get populated when launched from the music scope.
It seems we aren't checking for the existence of the queue table before attempting to clear it, before populating with songs sent from the scope.
This one line fix adds the createQueue(); to ensure the table exists.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:739
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~popey/music-app/fix-1392587/+merge/241770/+edit-commit-message

http://91.189.93.70:8080/job/music-app-remix-ci/265/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/214
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/214/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-vivid-amd64-ci/40

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/265/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Oliver Grawert (ogra) wrote :

looks good, approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'meta-database.js'
2--- meta-database.js 2014-11-11 23:26:58 +0000
3+++ meta-database.js 2014-11-14 09:20:52 +0000
4@@ -34,6 +34,7 @@
5 var db = getDatabase();
6 db.transaction(
7 function(tx) {
8+ createQueue();
9 tx.executeSql('DELETE FROM queue');
10 });
11 }

Subscribers

People subscribed via source and target branches