Merge lp:~popey/music-app/add-authors into lp:music-app
Proposed by
Alan Pope 🍺🐧🐱 🦄
on 2015-07-06
| Status: | Merged |
|---|---|
| Approved by: | Andrew Hayzen on 2015-07-07 |
| Approved revision: | 882 |
| Merged at revision: | 882 |
| Proposed branch: | lp:~popey/music-app/add-authors |
| Merge into: | lp:music-app |
| Diff against target: |
44 lines (+40/-0) 1 file modified
AUTHORS (+40/-0) |
| To merge this branch: | bzr merge lp:~popey/music-app/add-authors |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Hayzen | Approve on 2015-07-07 | ||
| Victor Thompson | Approve on 2015-07-06 | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve on 2015-07-06 | |
| Daniel Holbach (community) | 2015-07-06 | Approve on 2015-07-06 | |
|
Review via email:
|
|||
Commit Message
Add AUTHORS file
Description of the Change
Simple addition of an "AUTHORS" file, thanking those who have contributed to the application over the years. Please keep up to date when new contributors are identified.
To post a comment you must log in.
review:
Needs Fixing
(continuous-integration)
PASSED: Continuous integration, rev:882
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://
review:
Approve
(continuous-integration)
| Victor Thompson (vthompson) wrote : | # |
I'm a fan of the Oxford comma--but otherwise lgtm! :)
Also, the grammar of the second sentence might be a bit off (around "which"). Perhaps:
In addition, the numerous translations, bug reports, and other non-code contributions have been equally valuable.
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:882
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
SUCCESS: http://
Click here to trigger a rebuild:
http://