Code review comment for lp:~poliva/ubuntu/precise/wpasupplicant/fix-for-994739

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

.pc/applied-patches and debian/patches/series list fix_driver_wext_for_broadcom_wl.patch; but it's not shown in the diff. I think you may have forgotten to bzr add that new file :)

Otherwise it looks right in principle, but we ought to have this patch applied in Quantal first. It should be trivial anyway and totally reproduceable there. I wish this patch was accepted upstream as well, but it probably just needs to be brought up on the ML again.

I'll gladly sponsor this to quantal and precise once the missing file is added and same behavior can be confirmed in Quantal; which should be the case anyway. Coordination for that test is being done on bug 994739.

review: Needs Fixing

« Back to merge proposal