Merge lp:~png2378/elementaryos/order-epiphany-menu-actions into lp:~elementary-os/elementaryos/os-patch-epiphany-browser-xenial

Proposed by Maxim Taranov on 2016-09-20
Status: Needs review
Proposed branch: lp:~png2378/elementaryos/order-epiphany-menu-actions
Merge into: lp:~elementary-os/elementaryos/os-patch-epiphany-browser-xenial
Diff against target: 20 lines (+5/-2)
1 file modified
debian/patches/99_menu_add_preferences.patch (+5/-2)
To merge this branch: bzr merge lp:~png2378/elementaryos/order-epiphany-menu-actions
Reviewer Review Type Date Requested Status
elementary OS team 2016-09-20 Pending
Review via email: mp+306240@code.launchpad.net

Commit message

Change the order of menu actions for better consistency between apps

To post a comment you must log in.
Cody Garver (codygarver) wrote :

Maybe About should get removed, let's ask Dan what he thinks.

Daniel Fore (danrabbit) wrote :

I'm indifferent. It doesn't have an elementary-style About dialog so it could go either way

Unmerged revisions

9. By Maxim Taranov on 2016-09-20

Change the order of menu actions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/99_menu_add_preferences.patch'
2--- debian/patches/99_menu_add_preferences.patch 2016-06-10 20:53:01 +0000
3+++ debian/patches/99_menu_add_preferences.patch 2016-09-20 15:38:02 +0000
4@@ -8,11 +8,14 @@
5 <separator name="FileSep5"/>
6 <menuitem name="HistoryEditMenu" action="EditHistory"/>
7 <menu name="BookmarksMenu" action="Bookmarks">
8-@@ -47,6 +46,7 @@
9+@@ -44,6 +44,7 @@
10+ <menuitem name="ViewPageSourceMenu" action="ViewPageSource"/>
11+ <separator name="FileSep7"/>
12+ <menuitem name="HelpContentsMenu" action="HelpContents"/>
13++ <menuitem name="EditPreferencesMenu" action="EditPreferences"/>
14 <menuitem name="HelpAboutMenu" action="HelpAbout"/>
15 <menuitem name="FileCloseWindowMenu" action="FileCloseTab"/>
16 <menuitem name="FileQuitMenu" action="FileQuit"/>
17-+ <menuitem name="EditPreferencesMenu" action="EditPreferences"/>
18 </popup>
19
20 <accelerator name="AlwaysStopAccel" action="ViewAlwaysStop"/>

Subscribers

People subscribed via source and target branches