Code review comment for lp:~pmarchwiak/synapse-project/recoll-plugin

Revision history for this message
Patrick Marchwiak (pmarchwiak) wrote :

I understand your concern.

I feel there's more motivation for the action approach with "Locate" since it is quite common for users to have a large enough number of files that it would take too long to run. I don't see how checking a regex would help in the search index situation, since anything a user types is a valid search. In my (limited) testing on a more recent i5 laptop as well as an older core duo laptop, results have been quick to return with this plugin. However, I do appreciate that spawning a process could be taxing on other systems. The other drawback of hiding it behind an action is that it would require additional keystrokes to get to the results, which makes it less useful to me.

I'm not sure when I'll find the free time, but I will consider making hiding it behind an action.

« Back to merge proposal