Code review comment for lp:~pmarchwiak/synapse-project/recoll-plugin

Revision history for this message
Michal Hruby (mhr3) wrote :

Thanks for the contribution, it's looking pretty good, although I do have one gripe:

I'm not a fan of spawning processes in the search() method of an ItemProvider plugin - this is called on every keystroke and is pretty heavy on the system. That's why "Locate" is hidden behind an action, and before calculating with `bc` the query is first checked against a regex. Could you please do something like that?

Otherwise, the code is clean, nice job ;)

« Back to merge proposal