Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/nextYearFix

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> 82 + //To make horizontal movement smooth, not using bindig for
> year
> 83 + /*Component.onCompleted: {
> 84 + year = getYear();
> 85 + }
> 86 +
> 87 + Connections{
> 88 + target:root
> 89 + onMovementEnded: {
> 90 + //update only when movement ends, to avoid
> calculation while animation
> 91 + year = getYear();
> 92 + }
> 93 + }*/
> 94 +
>
> Is this commented out code a leftover? Can it be removed?

Hi, I will remove it for now,
But it's possible, can you checkout this code and see how it works ?
This code I wrote to avoid lag while changing year by swiping left right. on my device it seems to work good, I commented out code as it was failing test case.

But if you find code it good then I can try to fix testcase instead and keep this code.

« Back to merge proposal