Merge lp:~pkunal-parmar/ubuntu-calendar-app/dayviewfix_1240147 into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 152
Merged at revision: 152
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/dayviewfix_1240147
Merge into: lp:ubuntu-calendar-app
Diff against target: 49 lines (+22/-0)
2 files modified
DayView.qml (+20/-0)
TimeLineBaseComponent.qml (+2/-0)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/dayviewfix_1240147
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+191401@code.launchpad.net

Commit message

Fix for chequered pattern in dayview

Description of the change

Fix for chequered pattern in dayview

To post a comment you must log in.
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Works fine :)

Thank you Kunal

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DayView.qml'
2--- DayView.qml 2013-09-28 03:48:02 +0000
3+++ DayView.qml 2013-10-16 13:22:43 +0000
4@@ -39,6 +39,8 @@
5 objectName: "DayViewPathBase"
6
7 property var startDay: currentDay
8+ //This is used to scroll all view together when currentItem scrolls
9+ property var childContentY;
10
11 preferredHighlightBegin: 0.5
12 preferredHighlightEnd: 0.5
13@@ -73,6 +75,24 @@
14 height: parent.height
15 z: index == dayViewPath.currentIndex ? 2 : 1
16
17+ //get contentY value from PathView, if its not current Item
18+ Binding{
19+ target: timeLineView
20+ property: "contentY"
21+ value: dayViewPath.childContentY;
22+ when: !timeLineView.PathView.isCurrentItem
23+ }
24+
25+ //set PathView's contentY property, if its current item
26+ Binding{
27+ target: dayViewPath
28+ property: "childContentY"
29+ value: contentY
30+ when: timeLineView.PathView.isCurrentItem
31+ }
32+
33+ contentInteractive: timeLineView.PathView.isCurrentItem
34+
35 startDay: getStartDay()
36
37 function getStartDay() {
38
39=== modified file 'TimeLineBaseComponent.qml'
40--- TimeLineBaseComponent.qml 2013-09-16 14:04:01 +0000
41+++ TimeLineBaseComponent.qml 2013-10-16 13:22:43 +0000
42@@ -7,6 +7,8 @@
43 id: root
44
45 property var startDay: DateExt.today();
46+ property alias contentY: timeLineView.contentY
47+ property alias contentInteractive: timeLineView.interactive
48
49 property int type: typeWeek
50

Subscribers

People subscribed via source and target branches

to status/vote changes: